Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pluggable grid framework #231

Closed
agitator opened this issue Aug 5, 2016 · 3 comments · Fixed by #264
Closed

Remove pluggable grid framework #231

agitator opened this issue Aug 5, 2016 · 3 comments · Fixed by #264

Comments

@agitator
Copy link
Member

agitator commented Aug 5, 2016

  • use bs3 or bs4 grid?
  • re-use existing mosaic grid class names

i guess this will have consequences for the editor itself,
but there should be no visual difference for the user

maybe it's enough to strip down deco styling to the absolute minimum,
or put minimum required styles into an edit-grid stylesheet

@datakurre
Copy link
Member

The challenge here is that Mosaic is designed to be grid system agnostic and the editor has no idea of the target grid system. The markup created by Mosaic is transformed into the final grid specific syntax by the grid transform in plone.app.blocks.

So, stripping down deco styling to the absolute minimum and/or making it possible to "theme" it with the final grid would be nice.

@vangheem
Copy link
Member

vangheem commented Aug 7, 2016

I think we should consider doing away with pluggable grid systems. I think it's unnecessary and it seems reasonable to me that people using mosaic would need to buy into a certain grid system just for mosaic areas on the page. All grids do the same thing more or less.

@datakurre
Copy link
Member

To be honest, the grid annotation syntax could probably be replaced with bs grid classes without loss of information. Also the current trend seems to be towards BS 3/4 -style grid classes.

Meanwhile, we could simply replace deco CSS with BS3/4 based grid by building BS3/4 grid with mosaic class names.

On 7. elokuuta 2016 klo 3.42 +0300, Nathan Van Gheem notifications@github.com, wrote:

I think we should consider doing away with pluggable grid systems. I think it's unnecessary and it seems reasonable to me that people using mosaic would need to buy into a certain grid system just for mosaic areas on the page. All grids do the same thing more or less.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub (#231 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAJyvwbiX_gcT5YQZS_1iyyLjjyT1abHks5qdSntgaJpZM4JdbnN).

@vangheem vangheem added this to the Mephisto Sprint 2016 milestone Sep 5, 2016
@vangheem vangheem changed the title same grid system for view and edit Remove pluggable grid framework Sep 5, 2016
agitator added a commit that referenced this issue Sep 6, 2016
agitator added a commit that referenced this issue Sep 6, 2016
agitator added a commit that referenced this issue Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants