Fix two issues with form modals #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call (single argument) was intended in modal close scenario; this lead to exception, now fixed.
|
LGTM |
|
Am I right this needs a rebuild of the js in Products.CMFPlone? |
|
of course it does - I'm recompiling bundles right now :-) |
seanupton
added a commit
to upiq/Products.CMFPlone
that referenced
this pull request
Jun 19, 2017
seanupton
added a commit
to upiq/Products.CMFPlone
that referenced
this pull request
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR should close:
These were getting in the way of reasonable plone.schemaeditor operation in Plone 5.1/master, and really need to make it into Products.CMFPlone 5.1b4, if we can.
@thet can you take a look.