Base tag differs from actual URL #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodfersou
force-pushed
the
issue_86
branch
2 times, most recently
from
07aa14d
to
f5a7f6b
Compare
|
@plone/framework-team can someone take a look at these PR please? |
|
@rodfersou needs rebase, thanks! |
|
@jensens done |
|
@jensens don't forget that this pull request is related with this pull request too: plone/plone.app.layout#87 |
|
New jenkins job: http://jenkins.plone.org/job/pull-request-4.3/369/console |
|
ok from my side. I'd like to have someone with more insight on base tag to have a quick look. @thet, iirc you fiddled in past with base tags? This needs merge together with plone/plone.app.layout/pull/87 |
|
do we need this in 5.1 too or was this fixed there alrready? |
|
this is for Plone 4 only; on Plone 5 the |
|
👏 |
This was referenced May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes plone/plone.app.layout#86