Tile edit overlay shows up twice with Plone 4.3-latest and p.a.widgets-1.x installed

[petschki]

With latest Plone 4.3 and p.a.widgets 1.x branch installed the edit tile overlays show up twice. This is due to classname "pat-plone-modal" on a.edit-tile-link which registers the plone modal additionally to the $.fn.prepOverlay() in compose.js ... looks like this:

I don't want to disable prepOverlay because its used systemwide in Plone 4.3 .. my recommendation is to remove the pat-plone-modal classname as the Tiny editor for example isn't initialized correctly anyway. Without the pat-plone-modal class it looks OK:

If you're with me, I'll make a small pull request on this.

[petschki]

Well ... after some more investigations on the compose.js code I've changed my mind ;) I think it would be better to check for installed require.js before initalizing prepOverlay() and let the pat-plone-modal do it's job instead of prepOverlay() ... I've already fixed the JS code but right now I'm fighting with get_tinymce_options() to get the right context to adapt... maybe someone had this fight already?

[petschki]

Well well ... time goes by ... I have to admit, that this issue sounded quite familiar. Looking at issue #543 I've realized, that I've already forked cover and implemented a working richt text modal. Now I've made a pull request which fixes Plone 4.3/p.a.widgets 1.x issues ... see #720

[hvelarde]

rereading the issue I want to ask you if this happens with latest version of Plone only; if that the case then this needs to be fixed differently as should be related with plone/Products.CMFPlone#1710; let us know.

[petschki]

I'm not sure what your mentioned issue has to do with this one ... but I can confirm, that this bug also occurs on Plone 4.3.11 with p.a.widgets 1.x ... same effect: double overlay.

[hvelarde]

ok, then is not related; thanks!

[Mubra]

Hi @petschki , I can't explain this behavior, will you have a recipe?