Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0] Collections now use the Validation component #12376

Merged
merged 1 commit into from
Oct 19, 2018
Merged

[4.0.0] Collections now use the Validation component #12376

merged 1 commit into from
Oct 19, 2018

Conversation

SidRoberts
Copy link
Contributor

@SidRoberts SidRoberts commented Oct 30, 2016

Refs: #12098

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 31, 2016
@Jurigag
Copy link
Contributor

Jurigag commented Nov 9, 2016

Adding this already to 3.x.0 won't be hard and still BC with old way. Only instanceof checks and that's it. Question is - are we want do it ?

I can do PR with solution.

@Jurigag
Copy link
Contributor

Jurigag commented Dec 3, 2016

Well im adding this for 3.1.0 with BC. So in your PR there will be only need to remove old ability and and old classess.

@SidRoberts
Copy link
Contributor Author

I had to remove some files from ext/ because, previously, AppVeyor reached 100 errors and would stop compiling.

@sergeyklay
Copy link
Contributor

Let me deal with this a bit later. I'll try to sort out tomorrow.

@sergeyklay sergeyklay self-assigned this Aug 28, 2017
@sergeyklay
Copy link
Contributor

sergeyklay commented Sep 2, 2017

@SidRoberts I regenerated the build and updated ext/ dir. Could you please rebase

@sergeyklay sergeyklay assigned SidRoberts and unassigned sergeyklay Sep 2, 2017
@niden
Copy link
Sponsor Member

niden commented Oct 19, 2018

Thank you!

@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label Oct 19, 2018
@SidRoberts SidRoberts deleted the v4-collection-validation branch March 12, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants