Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code #12098

Closed
12 tasks done
sergeyklay opened this issue Aug 5, 2016 · 5 comments
Closed
12 tasks done

Remove deprecated code #12098

sergeyklay opened this issue Aug 5, 2016 · 5 comments
Labels
breaks bc Functionality that breaks Backwards Compatibility
Milestone
4.0.0

Comments

@sergeyklay
Copy link
Contributor

sergeyklay commented Aug 5, 2016 •
edited by niden
Loading

  • Remove Phalcon\Mvc\Model\Criteria::order in favor of Phalcon\Mvc\Model\Criteria::orderBy
  • Remove Phalcon\Mvc\Model\Validator\* in favor of Phalcon\Validation\Validator\*
  • Remove Phalcon\Cache\Backend\Memcache in favor of Phalcon\Cache\Backend\Libmemcached
  • Remove Phalcon\Session\Adapter\Memcache in favor of Phalcon\Session\Adapter\Libmemcached
  • Remove Phalcon\Debug::getMajorVersion due to the fact that we never use this method
  • Remove Phalcon\Mvc\Collection::validationHasFailed
  • Remove calling Phalcon\Mvc\Collection::validate with object of type Phalcon\Mvc\Model\ValidatorInterface
  • Refactor *\Apc classes to drop APC in favor of APCu
    The apc extension is considered unmaintained and dead.
    See: http://php.net/manual/en/intro.apc.php
  • Remove Phalcon\Mvc\Micro\Lazyloader::__call in favor of Phalcon\Mvc\Micro\Lazyloader::callMethod
  • Remove Phalcon\Cli\Console::addModules in favor of Phalcon\Cli\Console::registerModules
  • The xcache support should be deprecated as xcache is not compatible with the often by default enabled opcache extension. The xcache will not available for PHP 7
  • Remove Phalcon\Dispatcher::setModelBinding in favor of Phalcon\Dispatcher::setModelBinder
@sergeyklay sergeyklay added this to the 4.0.0 milestone Aug 5, 2016
@sergeyklay sergeyklay changed the title Remove Phalcon\Mvc\Model\Validator\* in favor of Phalcon\Validation\Validator\* Remove deprecated code Aug 5, 2016
@Jurigag
Copy link
Contributor

Jurigag commented Aug 5, 2016

I just wonder why we didn't did it in 3.0.0 already.

@sergeyklay
Copy link
Contributor Author

We just deprecated it in 3.0.0, but not removed

@sergeyklay sergeyklay mentioned this issue Aug 12, 2016
Closed
@sergeyklay sergeyklay mentioned this issue Oct 29, 2016
Merged
7 tasks
This was referenced Oct 31, 2016
Merged
Merged
@ruudboon
Copy link
Member

Will the Phalcon\Mvc\Model\Validation* be removed in 3.1? Don't see why we should keep it any longer. If it's deprecated I expect that it should still be possible to use. Don't think that's the case (#12178)

@Jurigag
Copy link
Contributor

Jurigag commented Nov 29, 2016

Because of collection. It will be removed in 4.0.0

@sergeyklay sergeyklay mentioned this issue Feb 27, 2017
Closed
3 tasks
This was referenced Apr 12, 2017
Merged
Merged
@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label Jul 17, 2017
@stale stale bot added the stale Stale issue - automatically closed label Apr 16, 2018
@sergeyklay sergeyklay reopened this May 2, 2018
@stale stale bot removed the stale Stale issue - automatically closed label May 2, 2018
@phalcon phalcon deleted a comment from stale bot Dec 8, 2018
@niden niden mentioned this issue Dec 8, 2018
Merged
3 tasks
niden added a commit that referenced this issue Dec 10, 2018
@niden
Merge branch 'niden-T12098-remove-deprecated-code' into 4.0.x
14c759e 
* niden-T12098-remove-deprecated-code:
  [#12098] - Corrected interfaces and tests
  [#12098] - Changelog corrections
  [#12098] - Docblock corrections
  [#12098] - Changed double quotes to single
  [#12098] - Minor correction
  [#12098] - Corrected file
  [#12098] - Fixed docblocks for tests; Restored missing test
  [4.0.x] - Removed obsolete tests; Added docblocks
  [#12098] - Corrected path
  [#12098] - Added zephir downloading command
  [#12098] - Corrected test
  [#12098] - Added the resetInput again
  [#12098] - Updates to the CHANGELOG
  [#12098] - Removed deprecated code
@niden
Copy link
Sponsor Member

niden commented Dec 10, 2018

This has been addressed

@niden niden closed this as completed Dec 10, 2018
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
4 participants
@niden @sergeyklay @ruudboon @Jurigag