Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformize default popup size #328

Closed
gtache opened this issue Dec 22, 2023 · 1 comment
Closed

Uniformize default popup size #328

gtache opened this issue Dec 22, 2023 · 1 comment

Comments

@gtache
Copy link
Contributor

gtache commented Dec 22, 2023

At the moment, the text annotation has a different initial popup size from the other annotations. It would be better to always have the same size for the sake of consistency.
gtache pushed a commit to gtache/icepdf that referenced this issue Dec 22, 2023
pcorlessGH-328 Allows setting default width and height of popup and u…
4f3b56d 
…ses the same values for all the annotations
@gtache gtache mentioned this issue Dec 22, 2023
Closed
pcorless pushed a commit that referenced this issue Jan 23, 2024
GH-328 normalize popup size relative to page size.
97d3f52
pcorless added a commit that referenced this issue Jan 25, 2024
@pcorless
GH-328 normalize popup size relative to page size. (#332)
a286485 
Co-authored-by: Patrick Corless <patrick.corless@arterys.com>
@pcorless
Copy link
Owner

Close thins for now. Please open again if I made incorrect assumptions.

@pcorless pcorless mentioned this issue Feb 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uniformizes initial popup size gtache/icepdf
2 participants
@pcorless @gtache