-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refac] Add pyq noise #469
Draft
EthanObadia
wants to merge
23
commits into
main
Choose a base branch
from
eo/run_dm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+227
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elif ( | ||
is_single_qubit_chain(block) | ||
and config.use_single_qubit_composition | ||
and all([not isinstance(b, NoisyPrimitiveBlock) for b in block]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
came here to suggest this, nice that you spotted it already @EthanObadia
run
and run_dm
in the backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue includes several tasks for refactoring and adding noise in
Qadence
:Merge
run
andrun_dm
in the backends:run_dm
method from the abstract classBackend
, theHorcrux
,Bracket
andPyqtorch
classes..run_dm
andrun
methods in thePulser
backend class.unpyqfy
method to represent the output density matrix as tensor.Closes [Feature] Enable noisy simulations through
run()
#428Add the noise gates from
pyq
:noise
parameter to thePrimitiveBlock
classnoise
parameter to theParametricBlock
classPrimitive
andParametric
block instances class to support thenoise
attribute.pyq
's protocols to theNoise
Class.convert_block
function:pyq
:Closes [Proto] Integrate the Pyqtorch's noisy simulation #423
Add the noise features:
(Will open an issue)