Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow None legend edge #221

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Allow None legend edge #221

merged 2 commits into from
Dec 29, 2022

Conversation

mepland
Copy link
Collaborator

@mepland mepland commented Dec 28, 2022 •
edited
Loading

Do not draw the legend frame when colors['legend_edge'] is None.

parrt
parrt reviewed Dec 28, 2022
View reviewed changes
dtreeviz/trees.py Outdated Show resolved Hide resolved
@parrt parrt added the enhancement New feature or request label Dec 29, 2022
@parrt parrt modified the milestones: 2.0, 0.2.1, 2.1 Dec 29, 2022
@parrt parrt merged commit ce8fb52 into parrt:dev Dec 29, 2022
@parrt
Copy link
Owner

parrt commented Dec 29, 2022 •
edited
Loading

refactored code works! Screenshot 2022-12-28 at 5 32 14 PM

haven't tried the "no legend edge"

@mepland mepland mentioned this pull request Jan 2, 2023
Closed
@mepland mepland deleted the allow_None_legend_edge branch January 14, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parrt parrt parrt left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mepland @parrt