Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctree_leaf_distributions() should use the classnames not classes #202

Closed
parrt opened this issue Dec 3, 2022 · 2 comments
Closed

ctree_leaf_distributions() should use the classnames not classes #202

parrt opened this issue Dec 3, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@parrt
Copy link
Owner

parrt commented Dec 3, 2022

Line 1549 of trees.py func ctree_leaf_distributions() should use the classnames not classes:

ax.legend([bar_container0, bar_container1],
          [f'class {self.shadow_tree.classes()[0]}', f'class {self.shadow_tree.classes()[1]}'])

Screenshot 2022-12-03 at 1 08 41 PM

@parrt parrt added the bug Something isn't working label Dec 3, 2022
@parrt parrt added this to the 2.0 milestone Dec 3, 2022
@parrt
Copy link
Owner Author

parrt commented Dec 26, 2022

Actually, it looks like that function is also limited to binary Target where as it should be any number of target. And I guess the code can simply call add_classifier_legend() instead of creating its own legend.

@parrt parrt removed this from the 2.0 milestone Dec 26, 2022
@mepland
Copy link
Collaborator

mepland commented Jan 2, 2023

@parrt fixed in #221

@parrt parrt added this to the 2.1 milestone Jan 2, 2023
@parrt parrt closed this as completed Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants