This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Generate storage info for aura pallet #9371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
KiChjang
requested review from
shawntabrizi,
apopiak,
coriolinus,
gui1117 and
emostov
|
just a reminder to update node-template runtime since it uses pallet-aura :) |
emostov
reviewed
Jul 19, 2021
gui1117
reviewed
Jul 19, 2021
frame/aura/src/lib.rs
Outdated
| if last_authorities != next_authorities { | ||
| let bounded = match next_authorities.try_into() { | ||
| Ok(v) => v, | ||
| Err(_) => return, |
There was a problem hiding this comment.
we should at least log an error, on_new_session shouldn't really be allowed to fail to set the authorities.
I don't know what is consequences of this if it happens.
Maybe better to use a WeakBoundedVec no ?
There was a problem hiding this comment.
In #8640, what we did instead is to truncate the authorities so that we're only left with the first n number of authorities, where n is the value of T::MaxAuthorities. I guess a WeakBoundedVec would work here as well -- it'll just mean that no additional authorities can be inserted, a removal must happen in order to reduce the number back down to n or below it.
apopiak
reviewed
Jul 20, 2021
kianenigma
reviewed
Jul 22, 2021
kianenigma
reviewed
Jul 22, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2021
* Migrate Aura pallet to BoundedVec Implementing issue #8629 * Fixed aura tests after BoundedVec change * Moved Vec to BoundedVec in authority-discovery * Merging into the main branch * Added MaxEncodedLen to crypto Need this without full_crypto to be able to add generate_store_info * Add generate_store_info for aura * Adding changes to Slot to add MaxEncodedLen * Adding generate_store_info to authority discovery * fmt * removing panics in runtime if vec size too large * authority-discovery: Remove panics in runtime Can happen if vec size is too large, so truncate the vec in that case * Adding logging when I truncate Vecs * Got the sign the other way around * Reverting pallet_aura changes This is already being addressed by PR #9371 * Change BoundedVec to WeakBoundedVec More robust implementation following @thiolliere recommendation. Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
gui1117
approved these changes
Sep 1, 2021
|
needs to make CI happy, but looks good to me otherwise |
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of paritytech/polkadot-sdk#323.
polkadot companion: paritytech/polkadot#3487