This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
fix cli: make rpc port Option<u16> again #14088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
niklasad1
added
A0-please_review
This was referenced May 7, 2023
bkchr
approved these changes
May 7, 2023
davxy
approved these changes
May 7, 2023
|
bot merge |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #13384
It changed the rpc_port from a
Option<u16>->u16which broke overriding it in cumulus (see paritytech/cumulus#2529) and the default value was used insteadpolkadot companion: paritytech/polkadot#7192
cumulus companion: paritytech/cumulus#2539