Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

rpc server: break legacy CLI options and remove "backward compatible HTTP server" #13384

Merged
merged 29 commits into from
May 3, 2023

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Feb 14, 2023

Close #13049 #13561

The CLI options that are removed/or renamed are:

  1. --rpc--max--payload (replaced by --rpc--max-request-size and --rpc-max-response-size)
  2. --ws--max--out-buffer-capacity
  3. --ws-external (replaced by --rpc_external)
  4. --unsafe--ws--external (replaced by --unsafe-rpc-external)
  5. --ipc--path
  6. --ws-port (replaced by --rpc--port)
  7. --ws-max--connections (replaced by --rpc--max--connections)
  8. --rpc-http (replaced by --rpc-addr)
  9. --rpc-ws (replaced by --rpc-addr)

polkadot companion: paritytech/polkadot#6987

cumulus companion: paritytech/cumulus#2417

@niklasad1 niklasad1 added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels Feb 14, 2023
@niklasad1 niklasad1 changed the title rpc server: break legacy CLI options and remove HTTP server rpc server: break legacy CLI options and remove "backward compatible HTTP server" Feb 14, 2023
@stale
Copy link

stale bot commented Mar 18, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Mar 18, 2023
@niklasad1
Copy link
Member Author

not stale

@stale stale bot removed the A3-stale label Mar 20, 2023
@niklasad1 niklasad1 requested review from bkchr and lexnv March 20, 2023 08:59
client/cli/src/commands/run_cmd.rs Outdated Show resolved Hide resolved
client/service/src/lib.rs Outdated Show resolved Hide resolved
client/service/src/lib.rs Outdated Show resolved Hide resolved
DaMandal0rian added a commit to autonomys/infra that referenced this pull request Jun 24, 2023
- update devnet and gemini-3d snapshots
- remove system domain
- changes to node to be compatible with upstream changes paritytech/substrate#13384
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jul 11, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…HTTP server" (paritytech#13384)

* jsonrpsee v0.16

* breaking: remove old CLI configs

* remove patch.crates-io

* fix bad merge

* fix clippy

* fix bad merge

* fix grumbles

* Update client/service/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* revert block_in_place

* add issue link in todo

* Update client/cli/src/config.rs

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

* grumbles: add ipv6 loopback address

* Revert "grumbles: add ipv6 loopback address"

This reverts commit 3a0b1ec.

* remove nits

* bump zombienet version

* adress grumbles: provide structopt default_val_t

* remove duplicate from structopt

* bump zombienet v1.3.47

* bump zombienet version

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Javier Viola <javier@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove HTTP RPC server and remove outdated CLI options.
8 participants