Rename anonymous to pure proxy #12283
Conversation
shawntabrizi
added
E5-breaksapi
C1-low
There was a problem hiding this comment.
idea: It would have been awesome if somehow we could also generate a #[deprecated] section in the metadata. Then, tools like PJS api and subxt can still support the deprecated method name, but similar to #[deprecated] within rust, emit a warning that they should rename it to something else.
Might be a big engineering mountain to climb initially, but it could potentially ease the development downstream a lot.
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/parachain-technical-summit-next-steps/51/20 |
|
cc @jacogr |
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#6038 |
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
…ch/substrate into shawntabrizi-pure-proxy
|
bot merge |
|
I think this still causes major confusion because the word proxy is still used for two different things:
The number of people I've tried to explain the difference between Alice being a proxy and Bob being a different proxy is extremely confusing and I would suggest we call it |
This doesn't make any sense though. What does pure account express? What makes an account created to access via proxy more pure than one accessed via cryptographic key or multisig? |
* master: [Fix] parameter_types! dead code errors (#12340) [Feature] Sequential migration execution for try-runtime (#12319) bench: Use `_` instead of `::` in auto-generated file names (#12332) Fast Unstake Pallet (#12129) Rename anonymous to pure proxy (#12283) Migrate remaining old decl_* macros to the new pallet attribute macros (#12271) pallet-utility: Disallow none origin (#12321) Make automatic storage deposits resistant against changing deposit prices (#12083) Format templates and fix `--steps` default value (#12286) Bump `wasmtime` to 1.0.0 (#12317) Introduce 'intermediate_insert' method to hide implementation details (#12215) Bound staking storage items (#12230) Use `array-bytes` for All Array/Bytes/Hex Operations (#12190) BREAKING: Rename Origin (#12258) Use temporary db for benchmarking (#12254) rpc: Implement `chainSpec` RPC API (#12261) Import target block body during warp sync (#12300) Proper naming wrt expectations (#12311) [ci] Revert cancel-pipeline job (#12309)
|
@shawntabrizi don't you think calling this a proxy is a bad idea? Overloading the word
We use |
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/parachain-technical-summit-next-steps/51/22 |
|
I apologize for my earlier comment, I think it's merely the wiki that is still not up to date on the new language. |
* rename anon to pure proxy * remove old weight comments * fix merge * Update frame/proxy/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * fn pure -> fn create_pure Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Fixes: #7735
Gav noted in the forum that he has been using the term "pure proxy", so this is a simple rename which changes that.
https://forum.polkadot.network/t/parachain-technical-summit-next-steps/51/14?u=shawntabrizi
This should have no runtime breaking changes, but APIs like Polkadot JS will probably need to do a rename to make this functionality work again, and also to update the branding of this kind of proxy account.
polkadot companion: paritytech/polkadot#6038
cumulus companion: paritytech/cumulus#1667