Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BREAKING: Rename Origin #12258

Merged
merged 29 commits into from
Sep 20, 2022
Merged

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Sep 13, 2022

Renames Origin to RuntimeOrigin

polkadot companion: paritytech/polkadot#6020
cumulus companion: paritytech/cumulus#1628

#11736

Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA

@kianenigma kianenigma added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 14, 2022
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a few places where we have type OverarchingCall = ... These should also be renamed to RuntimeCall I presume?

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are to move forward, we should probably merge this sooner rather than later so there is one version that breaks a lot of things downstream, rather than two.

@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 16, 2022

I think we have a few places where we have type OverarchingCall = ... These should also be renamed to RuntimeCall I presume?

I assume this should be done in a separate PR. I will do that.

@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 17, 2022

@kianenigma I don't think OverarchingCall is something we can rename since the SendTransactionTypes trait is implemented to types that already define the RuntimeCall type associated type. This causes an error.

@shawntabrizi
Copy link
Member

bot merge

@paritytech-processbot paritytech-processbot bot merged commit a47f200 into paritytech:master Sep 20, 2022
@shawntabrizi
Copy link
Member

@Szegoo please feel free to add your polkadot address for a tip :)

@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 21, 2022

@Szegoo please feel free to add your polkadot address for a tip :)

I have added my address, thanks :)

@shawntabrizi
Copy link
Member

/tip medium

@substrate-tip-bot
Copy link

@shawntabrizi A medium tip was successfully submitted for Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

ordian added a commit that referenced this pull request Sep 23, 2022
* master:
  [Fix] parameter_types! dead code errors (#12340)
  [Feature] Sequential migration execution for try-runtime (#12319)
  bench: Use `_` instead  of `::` in auto-generated file names (#12332)
  Fast Unstake Pallet (#12129)
  Rename anonymous to pure proxy (#12283)
  Migrate remaining old decl_* macros to the new pallet attribute macros (#12271)
  pallet-utility: Disallow none origin (#12321)
  Make automatic storage deposits resistant against changing deposit prices (#12083)
  Format templates and fix `--steps` default value (#12286)
  Bump `wasmtime` to 1.0.0 (#12317)
  Introduce 'intermediate_insert' method to hide implementation details (#12215)
  Bound staking storage items (#12230)
  Use `array-bytes` for All Array/Bytes/Hex Operations (#12190)
  BREAKING: Rename Origin (#12258)
  Use temporary db for benchmarking (#12254)
  rpc: Implement `chainSpec` RPC API (#12261)
  Import target block body during warp sync (#12300)
  Proper naming wrt expectations (#12311)
  [ci] Revert cancel-pipeline job (#12309)
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* BREAKING: Rename Origin

* more renaming

* a bit more renaming

* fix

* more fixing

* fix in frame_support

* even more fixes

* fix

* small fix

* ...

* update .stderr

* docs

* update docs

* update docs

* docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants