This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
runtime/inclusion: fix availability_threshold #6931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-please_review
sandreim
approved these changes
Mar 21, 2023
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 2473f3e |
ordian
added a commit
that referenced
this pull request
Mar 23, 2023
* master: Bump parity-scale-codec to v 3.4.0 (#6945) XCM ExportMessage benchmark support (#6923) Vstam1/xcm admin origin (#6928) Ensure candidate-backing and provisioner exit on missing Overseer (#6939) move back to ci-linux@production image runtime/inclusion: fix availability_threshold (#6931) Companion for #13624 (#6924)
ordian
added a commit
that referenced
this pull request
Mar 23, 2023
* master: Bump parity-scale-codec to v 3.4.0 (#6945) XCM ExportMessage benchmark support (#6923) Vstam1/xcm admin origin (#6928) Ensure candidate-backing and provisioner exit on missing Overseer (#6939) move back to ci-linux@production image runtime/inclusion: fix availability_threshold (#6931) Companion for #13624 (#6924)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was giving incorrect results mostly affecting small networks. It doesn't affect production networks where
n_validatorsis currently at 200.For example, for 4 validators, we expect the result to be 3 (2f + 1), whereas it would have returned 4.
For 6 validators, it would have returned 4 instead of 5.