This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Vstam1/xcm admin origin #6928
Merged
Vstam1/xcm admin origin #6928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ae05e1 Add new associated type, AdminOrigin, bounded by EnsureOrigin trait in XCM pallet. Replace ensure_root() with ensure_origin() from a EnsureOrigin trait. Set AdminOrigin as EnsureRoot<AccountId> in xcm configs.
vstam1
added
A0-please_review
bkchr
approved these changes
Mar 21, 2023
ggwpez
added
B1-note_worthy
|
Pinging @gavofyork -- you have expressed concerns for this feature in person, but I recall in an earlier element conversation you mentioned that this may be desirable. Is this still the case? |
kianenigma
reviewed
Mar 22, 2023
| @@ -231,6 +231,9 @@ pub mod pallet { | |||
| /// `pallet_xcm::CurrentXcmVersion`. | |||
| type AdvertisedXcmVersion: Get<XcmVersion>; | |||
|
|
|||
| /// The origin that is allowed to call privileged operations on the XCM pallet | |||
There was a problem hiding this comment.
Suggested change
| /// The origin that is allowed to call privileged operations on the XCM pallet | |
| /// The origin that is allowed to call privileged operations on the XCM pallet. |
kianenigma
approved these changes
Mar 22, 2023
gavofyork
approved these changes
Mar 23, 2023
ordian
added a commit
that referenced
this pull request
Mar 23, 2023
* master: Bump parity-scale-codec to v 3.4.0 (#6945) XCM ExportMessage benchmark support (#6923) Vstam1/xcm admin origin (#6928) Ensure candidate-backing and provisioner exit on missing Overseer (#6939) move back to ci-linux@production image runtime/inclusion: fix availability_threshold (#6931) Companion for #13624 (#6924)
ordian
added a commit
that referenced
this pull request
Mar 23, 2023
* master: Bump parity-scale-codec to v 3.4.0 (#6945) XCM ExportMessage benchmark support (#6923) Vstam1/xcm admin origin (#6928) Ensure candidate-backing and provisioner exit on missing Overseer (#6939) move back to ci-linux@production image runtime/inclusion: fix availability_threshold (#6931) Companion for #13624 (#6924)
AurevoirXavier
added a commit
to darwinia-network/darwinia
that referenced
this pull request
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI from #6632. Commit 5ae05e1 cherry-picked as solution for #6442
cumulus companion: paritytech/cumulus#2356