Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

remove duplicated arm and fix version index #6884

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Mar 15, 2023

chatgpt tell me the second arm is unreachable

also explicitly annotate the version index and update the numbers to match xcm version

so the version index for each struct is the xcm version that struct is introduced

Screenshot 2023-03-15 at 9 38 53 PM

bkchr
bkchr previously approved these changes Mar 15, 2023
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 15, 2023
@bkchr bkchr dismissed their stale review March 15, 2023 10:27

Incorrrect.

@xlc xlc changed the title remove duplicated arm remove duplicated arm and fix version index Mar 15, 2023
xcm/src/lib.rs Show resolved Hide resolved
@xlc
Copy link
Contributor Author

xlc commented Mar 15, 2023

@bkchr we need to adjust the label

@gavofyork
Copy link
Member

Worth putting in a test?

@xlc
Copy link
Contributor Author

xlc commented Mar 15, 2023

I can add some tests tomorrow

@joepetrowski
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 177092c into paritytech:master Mar 16, 2023
@ghost

This comment was marked as off-topic.

@VadimSaveljev

This comment was marked as off-topic.

@ghost

This comment was marked as off-topic.

@xlc xlc deleted the fix-versioned-type branch March 16, 2023 23:23
@xlc
Copy link
Contributor Author

xlc commented Mar 16, 2023

@bkchr can you backport this to v0.9.38 and v0.9.39

@bkchr
Copy link
Member

bkchr commented Mar 17, 2023

@bkchr can you backport this to v0.9.38 and v0.9.39

It should already been worked on.

coderobe pushed a commit that referenced this pull request Mar 17, 2023
* remove duplicated arm

* annotate the version index

* add tests

* fmt
@coderobe coderobe mentioned this pull request Mar 17, 2023
14 tasks
coderobe pushed a commit that referenced this pull request Mar 17, 2023
* remove duplicated arm

* annotate the version index

* add tests

* fmt
coderobe pushed a commit that referenced this pull request Mar 17, 2023
* remove duplicated arm

* annotate the version index

* add tests

* fmt
@crystalin
Copy link

Can we check the labels please? it seems to introduce breaking changes

@ggwpez ggwpez added T6-XCM This PR/Issue is related to XCM. B1-note_worthy Changes should be noted in the release notes and removed B0-silent Changes should not be mentioned in any release notes labels Mar 17, 2023
ordian added a commit that referenced this pull request Mar 21, 2023
* master:
  kusama: enable dispute slashes (#5974)
  Introduce OpenGov into Polkadot (#6701)
  introduce new well known key (#6915)
  [CI] Add bootnode checking CI jobs (#6889)
  Bump parity-db (#6921)
  Handling timers for repeat dispute participation requests (#6901)
  [Companion #13634] keystore overhaul (iter2) (#6913)
  tweak some pattern matches to address a new clippy warning
  Bump ci-linux image for rust 1.68
  Revert "Update orchestra to the recent version (#6854)" (#6916)
  Deprecate Currency: Companion for #12951 (#6780)
  changelog: template fixup (#6907)
  [Companion #13615] Keystore overhaul (#6892)
  update weights (#6897)
  Fix approval voting test (#6898)
  parachains-runtime: Less cloning! (#6896)
  Testing Reversion Speed on Dispute Concluded Against (#6880)
  remove duplicated arm and fix version index (#6884)
ordian added a commit that referenced this pull request Mar 21, 2023
* master:
  kusama: enable dispute slashes (#5974)
  Introduce OpenGov into Polkadot (#6701)
  introduce new well known key (#6915)
  [CI] Add bootnode checking CI jobs (#6889)
  Bump parity-db (#6921)
  Handling timers for repeat dispute participation requests (#6901)
  [Companion #13634] keystore overhaul (iter2) (#6913)
  tweak some pattern matches to address a new clippy warning
  Bump ci-linux image for rust 1.68
  Revert "Update orchestra to the recent version (#6854)" (#6916)
  Deprecate Currency: Companion for #12951 (#6780)
  changelog: template fixup (#6907)
  [Companion #13615] Keystore overhaul (#6892)
  update weights (#6897)
  Fix approval voting test (#6898)
  parachains-runtime: Less cloning! (#6896)
  Testing Reversion Speed on Dispute Concluded Against (#6880)
  remove duplicated arm and fix version index (#6884)
tgmichel pushed a commit to moonbeam-foundation/polkadot that referenced this pull request Mar 23, 2023
* remove duplicated arm

* annotate the version index

* add tests

* fmt

# Conflicts:
#	xcm/Cargo.toml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants