This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Testing Reversion Speed on Dispute Concluded Against #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradleyOlson64
added
A0-please_review
sandreim
approved these changes
Mar 14, 2023
| gum::trace!( | ||
| target: LOG_TARGET, | ||
| ?revert_number, | ||
| ?revert_hash, |
There was a problem hiding this comment.
We should use same key as above: revert_hash or block_hash
s0me0ne-unkn0wn
approved these changes
Mar 14, 2023
| @@ -359,6 +359,9 @@ fn apply_ancestor_reversions( | |||
| // of unviability is only heavy on the first log. | |||
| for revert_number in reversions { | |||
| let maybe_block_entry = load_ancestor(backend, block_hash, block_number, revert_number)?; | |||
| if let Some(block_entry) = &maybe_block_entry { | |||
| gum::trace!(target: LOG_TARGET, ?revert_number, ?block_entry.block_hash, "Block marked as reverted via scraped on-chain reversions"); | |||
There was a problem hiding this comment.
nit: cargo fmt does not work for macros, it's not that critical, but it's better to fold the lines manually to fit into 100 chars
…brad-issue-6735
|
bot merge |
|
Error: Statuses failed for cd1e69c |
…brad-issue-6735
|
bot merge |
ordian
added a commit
that referenced
this pull request
Mar 21, 2023
* master: kusama: enable dispute slashes (#5974) Introduce OpenGov into Polkadot (#6701) introduce new well known key (#6915) [CI] Add bootnode checking CI jobs (#6889) Bump parity-db (#6921) Handling timers for repeat dispute participation requests (#6901) [Companion #13634] keystore overhaul (iter2) (#6913) tweak some pattern matches to address a new clippy warning Bump ci-linux image for rust 1.68 Revert "Update orchestra to the recent version (#6854)" (#6916) Deprecate Currency: Companion for #12951 (#6780) changelog: template fixup (#6907) [Companion #13615] Keystore overhaul (#6892) update weights (#6897) Fix approval voting test (#6898) parachains-runtime: Less cloning! (#6896) Testing Reversion Speed on Dispute Concluded Against (#6880) remove duplicated arm and fix version index (#6884)
ordian
added a commit
that referenced
this pull request
Mar 21, 2023
* master: kusama: enable dispute slashes (#5974) Introduce OpenGov into Polkadot (#6701) introduce new well known key (#6915) [CI] Add bootnode checking CI jobs (#6889) Bump parity-db (#6921) Handling timers for repeat dispute participation requests (#6901) [Companion #13634] keystore overhaul (iter2) (#6913) tweak some pattern matches to address a new clippy warning Bump ci-linux image for rust 1.68 Revert "Update orchestra to the recent version (#6854)" (#6916) Deprecate Currency: Companion for #12951 (#6780) changelog: template fixup (#6907) [Companion #13615] Keystore overhaul (#6892) update weights (#6897) Fix approval voting test (#6898) parachains-runtime: Less cloning! (#6896) Testing Reversion Speed on Dispute Concluded Against (#6880) remove duplicated arm and fix version index (#6884)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dispute has concluded against a parablock candidate we then want to revert all relay chain blocks on all forks including that candidate. Previously the signal to revert relay chain blocks was only passed on-chain. This meant at least one block worth of wasted effort from block builders as they waited for the concluded dispute to be seen in a block. This change #6512 created a new off-chain means of notifying chain selection when a dispute concludes.
The logs added in this PR allow us to get a coarse view as to whether the new off-chain means is giving us our expected performance boost.