Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BlockId removal: refactor of runtime API #6721

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Feb 15, 2023

It changes the first argument of all generated runtime API calls from: BlockId<Block> to: Block::Hash

This PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)

Companion for: paritytech/substrate#13255
cumulus companion: paritytech/cumulus#2190

@michalkucharczyk michalkucharczyk added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Feb 15, 2023
It changes the first argument of all generated runtime API calls from: `BlockId<Block>` to: `Block::Hash`
@michalkucharczyk michalkucharczyk requested a review from a team February 15, 2023 16:20
@michalkucharczyk michalkucharczyk changed the title BlockId removal: refactor of runtime API BlockId removal: refactor of runtime API Feb 15, 2023
@michalkucharczyk michalkucharczyk requested a review from a team February 16, 2023 07:17
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

node/test/client/src/block_builder.rs Show resolved Hide resolved
@michalkucharczyk
Copy link
Contributor Author

bor rebase

@michalkucharczyk
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit b5358e5 into master Feb 20, 2023
@paritytech-processbot paritytech-processbot bot deleted the mku-blockid-runtimeapi branch February 20, 2023 23:44
ordian added a commit that referenced this pull request Mar 16, 2023
* master: (98 commits)
  Ensure max_weight is assigned properly in AllowTopPaidExecutionFrom (#6787)
  Explicitly Handling ProvisionableData Cases (#6757)
  Companion for Substrate#12520 (#6730)
  Revert back to bare metal runners for weights generation (#6762)
  Improve XCM fuzzer (#6190)
  Corrected weight trader comment (#6752)
  clean up executed migrations (#6763)
  Remove state migration from westend runtime. (#6737)
  polkadot companion #12608 (Pools claim permissions) (#6753)
  Add Turboflakes bootnodes to Polkadot, Kusama and Westend (#6628)
  Companion for substrate#13284 (#6653)
  Companion for Substrate #13410: Introduce EnsureOrigin to democracy.propose (#6750)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#6734)
  Companion PR for PR#13119 (#6683)
  Companion for Substrate#13411: frame/beefy: prune entries in set id session mapping (#6743)
  `BlockId` removal: refactor of runtime API (#6721)
  Fix auction bench (#6747)
  Use PVF code paired with executor params wherever possible (#6742)
  Retire `OldV1SessionInfo` (#6744)
  Companion for substrate #13121 - BEEFY Equivocations support (#6593)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants