Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BlockId removal: refactor of runtime API #2190

Merged
merged 8 commits into from
Feb 21, 2023

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Feb 15, 2023

It changes the first argument of all generated runtime API calls from: BlockId<Block> to: Block::Hash

This PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)

Companion for: paritytech/substrate#13255

@michalkucharczyk michalkucharczyk added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 15, 2023
It changes the first argument of all generated runtime API calls from: `BlockId<Block>` to: `Block::Hash`
@michalkucharczyk michalkucharczyk changed the title mku blockid runtimeapi BlockId removal: refactor of runtime API Feb 15, 2023
@michalkucharczyk michalkucharczyk requested a review from a team February 15, 2023 16:19
@michalkucharczyk michalkucharczyk changed the title BlockId removal: refactor of runtime API BlockId removal: refactor of runtime API Feb 15, 2023
@michalkucharczyk michalkucharczyk requested a review from a team February 16, 2023 07:17
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalkucharczyk
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for c63fc23

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 5b42b5f into master Feb 21, 2023
@paritytech-processbot paritytech-processbot bot deleted the mku-blockid-runtimeapi branch February 21, 2023 00:23
ordian added a commit that referenced this pull request Feb 27, 2023
* master: (35 commits)
  add turboflakes system-chains bootnodes (#2223)
  Companion for #13349 (#2217)
  bump `zombienet` version to v1.3.35 (#2226)
  [ci] Return benchmark to bm machines (#2225)
  Collectives chain xcm filter (#2222)
  Add metaspan.io parachain boot nodes (#2218)
  Companion for #13390 (#2189)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219)
  Benchmarks script improvements (#2214)
  `BlockId` removal: refactor of runtime API (#2190)
  Rename .feature extension to .zndsl (#2215)
  Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213)
  WIP: Fix templates (#2204)
  Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201)
  Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161)
  Bump clap from 4.1.4 to 4.1.6 (#2193)
  Bump toml from 0.6.0 to 0.7.2 (#2170)
  companion for paritytech/polkadot#6161 (#2151)
  Bump serde_json from 1.0.92 to 1.0.93 (#2175)
  add warp_sync_params (#1909)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants