CLN:F-string in pandas/_libs/tslibs/*.pyx #29775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
force-pushed
the
CLN-fstings-tslibs
branch
from
b0e4445
to
580bb09
Compare
ShaharNaveh
force-pushed
the
CLN-fstings-tslibs
branch
from
580bb09
to
4ead557
Compare
pandas/_libs/tslibs/c_timestamp.pyx
Outdated
| f"to {type(obj).__name__} is deprecated, " | ||
| f"will be removed in a future " | ||
| f"version. Instead of adding/subtracting `n`, use " | ||
| f"`n * self.freq`" |
There was a problem hiding this comment.
@datapythonista was the decision that we are or are not putting the "f" one every line?
There was a problem hiding this comment.
IIRC that was the preferred option. To me it makes more sense.
There was a problem hiding this comment.
@datapythonista Do you think that it's something that is worth mentioning in the docs?
I mean, to sort the confusion once and for all?
ShaharNaveh
force-pushed
the
CLN-fstings-tslibs
branch
from
cb1f7c4
to
6ad7006
Compare
ShaharNaveh
force-pushed
the
CLN-fstings-tslibs
branch
from
6ad7006
to
58cbd77
Compare
|
thanks @MomIsBestFriend |
5 tasks
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Nov 25, 2019
…ndexing-1row-df * upstream/master: (185 commits) ENH: add BooleanArray extension array (pandas-dev#29555) DOC: Add link to dev calendar and meeting notes (pandas-dev#29737) ENH: Add built-in function for Styler to format the text displayed for missing values (pandas-dev#29118) DEPR: remove statsmodels/seaborn compat shims (pandas-dev#29822) DEPR: remove Index.summary (pandas-dev#29807) DEPR: passing an int to read_excel use_cols (pandas-dev#29795) STY: fstrings in io.pytables (pandas-dev#29758) BUG: Fix melt with mixed int/str columns (pandas-dev#29792) TST: add test for ffill/bfill for non unique multilevel (pandas-dev#29763) Changed description of parse_dates in read_excel(). (pandas-dev#29796) BUG: pivot_table not returning correct type when margin=True and aggfunc='mean' (pandas-dev#28248) REF: Create _lib/window directory (pandas-dev#29817) Fixed small mistake (pandas-dev#29815) minor cleanups (pandas-dev#29798) DEPR: enforce deprecations in core.internals (pandas-dev#29723) add test for unused level raises KeyError (pandas-dev#29760) Add documentation linking to sqlalchemy (pandas-dev#29373) io/parsers: ensure decimal is str on PythonParser (pandas-dev#29743) Reenabled no-unused-function (pandas-dev#29767) CLN:F-string in pandas/_libs/tslibs/*.pyx (pandas-dev#29775) ... # Conflicts: # pandas/tests/frame/indexing/test_indexing.py
5 tasks
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffref #29547