Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add link to dev calendar and meeting notes #29737

Merged
merged 5 commits into from
Nov 25, 2019

Conversation

TomAugspurger
Copy link
Contributor

No description provided.

@jreback jreback added this to the 1.0 milestone Nov 20, 2019
@jreback
Copy link
Contributor

jreback commented Nov 20, 2019

great idea! merge on green.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed good idea!

==================

We hold regular developer meetings on the second Wednesday
of each month at 12:00 US Central Time. These meetings and their minutes are open to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add U

Suggested change
of each month at 12:00 US Central Time. These meetings and their minutes are open to
of each month at 18:00 UTC / 12:00 US Central Time. These meetings and their minutes are open to

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I suppose the 12:00 central time is robust to summer/winter, and the UTC not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it's not robust :) Right now the calendar invite is set to US Central time (since I created it 😄).

But which do we want?

  1. A specific US timezone (So it's always the same local time for most US people. Will shift once or twice for people on other DST calendars).
  2. UTC (So the local time will shift for people doing DST transitions).

cc @pandas-dev/pandas-core.

How about a 🎉 if you want option 1 and 🚀 if you want option 2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the 12:00 central time (so using local time), I mainly wanted to have this translated to a local time that is familiar for a European as well :)

DST switches are not exactly equal (US: 2nd sunday of March, Europe: last sunda of March), but so since we are the second Wednesday, it's only in March that there can be a difference, and not even every year I think :)

So maybe you can put "19:00 Europe/Brussels" instead of the UTC ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm biased, because I'm in UTC, but I have a small preference for it. I feel people outside the US may somehow feel this is not for them, and I think we want the opposite. I think UTC feels neutral. If most people understand US Central time better than other time zones, may be we can just leave it, and add a small note (e.g. people from anywhere in the world welcome).

What would be good if to have the links to the calendars somewhere, so people can subscribe, and see in their current time zone (that's the main way I manage to know when are events).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the UTCs have it.

What would be good if to have the links to the calendars somewhere, so people can subscribe, and see in their current time zone (that's the main way I manage to know when are events).

This PR includes links, which you can subscribe to / import into your calendar. Or do you mean something else?

@TomAugspurger
Copy link
Contributor Author

Updated the Google calendar to be fixed to UTC, and updated the text in the docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure why I didn't see the links before, they look so clear now.

Looks good, couple of ideas for presentation, but feel free to ignore them if you're happy how it is.

doc/source/development/meeting.rst Outdated Show resolved Hide resolved
You can subscribe to this calendar with the following links:

* iCal: https://calendar.google.com/calendar/ical/pgbn14p6poja8a1cf2dv2jhrmg%40group.calendar.google.com/public/basic.ics
* Google calendar: https://calendar.google.com/calendar/embed?src=pgbn14p6poja8a1cf2dv2jhrmg%40group.calendar.google.com&ctz=America%2FChicago
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Google calendar: https://calendar.google.com/calendar/embed?src=pgbn14p6poja8a1cf2dv2jhrmg%40group.calendar.google.com&ctz=America%2FChicago
* `Google calendar <https://calendar.google.com/calendar/embed?src=pgbn14p6poja8a1cf2dv2jhrmg%40group.calendar.google.com>`_

doc/source/development/meeting.rst Outdated Show resolved Hide resolved
@TomAugspurger
Copy link
Contributor Author

Fixed the links and removed the tz from the URL

@TomAugspurger
Copy link
Contributor Author

OK, merging this in. I'd recommend subscribing to this calendar for meeting changes. Right now just Joris and I can edit it. Happy to add anyone else.

@TomAugspurger TomAugspurger merged commit 11cb423 into pandas-dev:master Nov 25, 2019
keechongtan added a commit to keechongtan/pandas that referenced this pull request Nov 25, 2019
…ndexing-1row-df

* upstream/master: (185 commits)
  ENH: add BooleanArray extension array (pandas-dev#29555)
  DOC: Add link to dev calendar and meeting notes (pandas-dev#29737)
  ENH: Add built-in function for Styler to format the text displayed for missing values (pandas-dev#29118)
  DEPR: remove statsmodels/seaborn compat shims (pandas-dev#29822)
  DEPR: remove Index.summary (pandas-dev#29807)
  DEPR: passing an int to read_excel use_cols (pandas-dev#29795)
  STY: fstrings in io.pytables (pandas-dev#29758)
  BUG: Fix melt with mixed int/str columns (pandas-dev#29792)
  TST: add test for ffill/bfill for non unique multilevel (pandas-dev#29763)
  Changed description of parse_dates in read_excel(). (pandas-dev#29796)
  BUG: pivot_table not returning correct type when margin=True and aggfunc='mean'  (pandas-dev#28248)
  REF: Create _lib/window directory (pandas-dev#29817)
  Fixed small mistake (pandas-dev#29815)
  minor cleanups (pandas-dev#29798)
  DEPR: enforce deprecations in core.internals (pandas-dev#29723)
  add test for unused level raises KeyError (pandas-dev#29760)
  Add documentation linking to sqlalchemy (pandas-dev#29373)
  io/parsers: ensure decimal is str on PythonParser (pandas-dev#29743)
  Reenabled no-unused-function (pandas-dev#29767)
  CLN:F-string in pandas/_libs/tslibs/*.pyx (pandas-dev#29775)
  ...

# Conflicts:
#	pandas/tests/frame/indexing/test_indexing.py
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants