Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: fix mypy error pandas/tests/plotting/test_backend.py #29016

Merged
merged 4 commits into from
Oct 16, 2019
Merged

CLN: fix mypy error pandas/tests/plotting/test_backend.py #29016

merged 4 commits into from
Oct 16, 2019

Commits on Oct 15, 2019

  1. CLN: fix mypy error pandas/tests/plotting/test_backend.py 

    GH28926, mypy didn't like setting non-existant attribute on module.
Dummy function, circumvented with __setattr__
    @saska
    saska committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    d545568 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Amended pandas-dev#29016 according to comments 

    Switched from obj.__setattr__(...) to setattr(obj, ...)
python/mypy#7171 (comment)
    @saska
    saska committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    0187f73 View commit details
    Browse the repository at this point in the history

  2. Resolve setup.cfg merge conflict

    @saska
    saska committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c7f03eb View commit details
    Browse the repository at this point in the history

  3. Fix broken merge 

    commit c7f03eb
    @saska
    saska committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    5a700a2 View commit details
    Browse the repository at this point in the history