CLN: fix mypy error pandas/tests/plotting/test_backend.py #29016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH28926, mypy didn't like setting non-existant attribute on module. Dummy function, circumvented with __setattr__
38 tasks
simonjayhawkins
requested changes
Oct 16, 2019
There was a problem hiding this comment.
@saskakarsi Thanks for the PR. minor change, also can you merge master
Switched from obj.__setattr__(...) to setattr(obj, ...) python/mypy#7171 (comment)
commit c7f03eb
simonjayhawkins
approved these changes
Oct 16, 2019
|
@TomAugspurger mind taking a look at this one? |
TomAugspurger
approved these changes
Oct 16, 2019
|
Thanks! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…#29016) * CLN: fix mypy error pandas/tests/plotting/test_backend.py GH28926, mypy didn't like setting non-existant attribute on module. Dummy function, circumvented with __setattr__
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…#29016) * CLN: fix mypy error pandas/tests/plotting/test_backend.py GH28926, mypy didn't like setting non-existant attribute on module. Dummy function, circumvented with __setattr__
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
…#29016) * CLN: fix mypy error pandas/tests/plotting/test_backend.py GH28926, mypy didn't like setting non-existant attribute on module. Dummy function, circumvented with __setattr__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH28926, mypy didn't like setting non-existant attribute on module.
Dummy function, circumvented with
__setattr__black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff