Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Fix mypy errors in pandas/tests/io/test_sql.py Reverted and added type changes #29006

Merged
merged 1 commit into from
Oct 16, 2019
Merged

CLN: Fix mypy errors in pandas/tests/io/test_sql.py Reverted and added type changes #29006

merged 1 commit into from
Oct 16, 2019

Conversation

aaditya-panik
Copy link
Contributor

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

ref closed PR #28979

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Oct 15, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Oct 15, 2019
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAyd WillAyd merged commit de67bb7 into pandas-dev:master Oct 16, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 16, 2019

Thanks @aaditya-panik

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants