Mypy fix/io sql #28979
Closed
Mypy fix/io sql #28979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Compat
4 tasks
38 tasks
simonjayhawkins
requested changes
Oct 15, 2019
There was a problem hiding this comment.
@aaditya-panik Thanks for the PR.
I think is you make the changes suggested, all the other changes can be reverted.
pandas/tests/io/test_sql.py
Outdated
| flavor = "sqlite" | ||
| mode = None | ||
| flavor = "sqlite" # type: Optional[str] | ||
| mode = None # type: Optional[str] |
There was a problem hiding this comment.
Suggested change
| mode = None # type: Optional[str] | |
| mode = None # type: str |
pandas/tests/io/test_sql.py
Outdated
| @@ -1234,7 +1236,7 @@ class _TestSQLAlchemy(SQLAlchemyMixIn, PandasSQLTest): | |||
|
|
|||
| """ | |||
|
|
|||
| flavor = None | |||
| flavor = None # type: Optional[str] | |||
There was a problem hiding this comment.
Suggested change
| flavor = None # type: Optional[str] | |
| flavor = None # type: str |
|
I will be creating and linking a new PR because I think I botched my forked repo branch. Will link the two PRs once I create the new one with the changes @simonjayhawkins suggested. |
3 tasks
|
@simonjayhawkins made the changes you suggested. Let me know if that works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAs part of this PR, did the following:
Variable typing.
Code cleanup and reformatting the imports.
Internal class
_TestSQLAlchemyConnbehaves like an abstract class.To solve variable name clashing between parent classes in some of the errors, I restructured the inheritance from a structure like
to
Not sure why it was like that unless I'm missing something?