Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: isort tests/scalar, tests/tslibs, import libwindow instead of _window #23787

Merged
merged 5 commits into from
Nov 20, 2018
Merged

STY: isort tests/scalar, tests/tslibs, import libwindow instead of _window #23787

merged 5 commits into from
Nov 20, 2018

Conversation

jbrockmendel
Copy link
Member

Ignore flake8 code "S001: found modulo formatter" which incorrectly picks up all % characters, i.e. gives false-positives on actual mod ops.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@jbrockmendel
Copy link
Member Author

Travis fail is the test_rank segfault

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 20, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 20, 2018
@jreback jreback merged commit b4c6632 into pandas-dev:master Nov 20, 2018
@jreback
Copy link
Contributor

jreback commented Nov 20, 2018

thanks!

@jbrockmendel jbrockmendel deleted the imports branch November 20, 2018 02:07
thoo added a commit to thoo/pandas that referenced this pull request Nov 20, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
0b0b072 
…fixed

* upstream/master:
  DOC: more consistent flake8-commands in contributing.rst (pandas-dev#23724)
  DOC: Fixed the doctsring for _set_axis_name (GH 22895) (pandas-dev#22969)
  DOC: Improve GL03 message re: blank lines at end of docstrings. (pandas-dev#23649)
  TST: add tests for keeping dtype in Series.update (pandas-dev#23604)
  TST: For GH4861, Period and datetime in multiindex (pandas-dev#23776)
  TST: move .str-test to strings.py & parametrize it; precursor to pandas-dev#23582 (pandas-dev#23777)
  STY: isort tests/scalar, tests/tslibs, import libwindow instead of _window (pandas-dev#23787)
  BUG: fixed .str.contains(..., na=False) for categorical series (pandas-dev#22170)
  BUG: Maintain column order with groupby.nth (pandas-dev#22811)
  API/DEPR: replace kwarg "pat" with "sep" in str.[r]partition (pandas-dev#23767)
  CLN: Finish isort core (pandas-dev#23765)
  TST: Mark test_pct_max_many_rows with pytest.mark.single (pandas-dev#23799)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
STY: isort tests/scalar, tests/tslibs, import libwindow instead of _w…
08f4e8f 
…indow (pandas-dev#23787)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
STY: isort tests/scalar, tests/tslibs, import libwindow instead of _w…
d93f6ed 
…indow (pandas-dev#23787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @pep8speaks @jreback