Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Finish isort core #23765

Merged
merged 4 commits into from
Nov 20, 2018
Merged

CLN: Finish isort core #23765

merged 4 commits into from
Nov 20, 2018

Conversation

alimcmaster1
Copy link
Member

@pep8speaks
Copy link

Hello @alimcmaster1! Thanks for submitting the PR.

from pandas.util._decorators import deprecate_kwarg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm what's with the empty lines between from statements here? Not seeing that anywhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are separate sections see the isort section in the setup.cfg for latest spec.

from pandas._libs import index as libindex
from pandas.util._decorators import Appender, cache_readonly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this supposed to be alphabetical? Should come after the following import, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within pandas imports are by dependency structure opposed to alphabetically - see this change #23366

@alimcmaster1
Copy link
Member Author

Thanks for taking a look @WillAyd just actually removed a bunch of files to aid reviewing this

@jreback jreback added this to the 0.24.0 milestone Nov 19, 2018
@jreback
Copy link
Contributor

jreback commented Nov 19, 2018

thanks @alimcmaster1

btw these are going really well, don't mind having more files in each PR.

@jreback
Copy link
Contributor

jreback commented Nov 19, 2018

ping on green.

@jreback
Copy link
Contributor

jreback commented Nov 19, 2018

small linting issue in the 3.6 build

run

LINT=1 ci/code_checks.sh

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #23765 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23765      +/-   ##
==========================================
+ Coverage   92.27%   92.28%   +0.01%     
==========================================
  Files         161      161              
  Lines       51411    51449      +38     
==========================================
+ Hits        47439    47481      +42     
+ Misses       3972     3968       -4
Flag Coverage Δ
#multiple 90.68% <100%> (+0.01%) ⬆️
#single 42.28% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/sparse/frame.py 94.86% <100%> (ø) ⬆️
pandas/core/arrays/base.py 97.35% <100%> (ø) ⬆️
pandas/core/arrays/datetimelike.py 95.96% <100%> (-0.19%) ⬇️
pandas/core/internals/blocks.py 93.67% <100%> (ø) ⬆️
pandas/core/sparse/series.py 95.53% <100%> (ø) ⬆️
pandas/core/arrays/period.py 98.44% <100%> (-0.01%) ⬇️
pandas/core/arrays/timedeltas.py 96.09% <100%> (+0.45%) ⬆️
pandas/core/arrays/datetimes.py 98.51% <100%> (ø) ⬆️
pandas/core/sparse/scipy_sparse.py 97.05% <100%> (ø) ⬆️
pandas/core/tools/timedeltas.py 98.03% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84cc0fb...5fe038e. Read the comment docs.

@jreback jreback merged commit 6fad5a0 into pandas-dev:master Nov 20, 2018
@jreback
Copy link
Contributor

jreback commented Nov 20, 2018

thanks @alimcmaster1

thoo added a commit to thoo/pandas that referenced this pull request Nov 20, 2018
…fixed

* upstream/master:
  DOC: more consistent flake8-commands in contributing.rst (pandas-dev#23724)
  DOC: Fixed the doctsring for _set_axis_name (GH 22895) (pandas-dev#22969)
  DOC: Improve GL03 message re: blank lines at end of docstrings. (pandas-dev#23649)
  TST: add tests for keeping dtype in Series.update (pandas-dev#23604)
  TST: For GH4861, Period and datetime in multiindex (pandas-dev#23776)
  TST: move .str-test to strings.py & parametrize it; precursor to pandas-dev#23582 (pandas-dev#23777)
  STY: isort tests/scalar, tests/tslibs, import libwindow instead of _window (pandas-dev#23787)
  BUG: fixed .str.contains(..., na=False) for categorical series (pandas-dev#22170)
  BUG: Maintain column order with groupby.nth (pandas-dev#22811)
  API/DEPR: replace kwarg "pat" with "sep" in str.[r]partition (pandas-dev#23767)
  CLN: Finish isort core (pandas-dev#23765)
  TST: Mark test_pct_max_many_rows with pytest.mark.single (pandas-dev#23799)
@alimcmaster1 alimcmaster1 deleted the isort-arrays branch November 20, 2018 08:23
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants