Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecosystem.rst to include Pint #22582

Closed
wants to merge 1 commit into from

Conversation

znicholls
Copy link
Contributor

@znicholls znicholls commented Sep 3, 2018

We are working on upgrading pint to be compatible with pandas, see hgrecco/pint#684

I am guessing that the line in the docs,

If you’re building a library that implements the interface, please publicize it on Extension Data Types.

meant something like this pull request. If that's completely wrong, apologies.

@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #22582 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22582   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51497    51497           
=======================================
  Hits        47530    47530           
  Misses       3967     3967
Flag Coverage Δ
#multiple 90.69% <ø> (ø) ⬆️
#single 42.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c90e5...93dd398. Read the comment docs.

@jbrockmendel
Copy link
Member

I’ll take a look at pint#684; units support have been an often-requested feature for pandas.

@mroeschke mroeschke added the Docs label Sep 4, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this needs a new release of pint yes? pls indicate the minimum version here.

doc/source/ecosystem.rst Outdated Show resolved Hide resolved
doc/source/ecosystem.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v0.23.5.txt Outdated Show resolved Hide resolved
@znicholls znicholls changed the title Update ecosystem.rst to include Pint WIP: Update ecosystem.rst to include Pint Sep 4, 2018
@znicholls znicholls mentioned this pull request Sep 6, 2018
5 tasks
@znicholls znicholls changed the title WIP: Update ecosystem.rst to include Pint Update ecosystem.rst to include Pint Sep 6, 2018
@znicholls
Copy link
Contributor Author

We know the version number from hgrecco/pint#693 (comment), can I do anything else?

@znicholls
Copy link
Contributor Author

@jreback @jbrockmendel any idea why this is failing..?

@jbrockmendel
Copy link
Member

any idea why this is failing..?

Looks like a CI bug that was cleared up a couple days ago. Try rebasing?

@znicholls znicholls force-pushed the patch-1 branch 2 times, most recently from 501bc97 to 2b55975 Compare September 6, 2018 22:27
@jreback
Copy link
Contributor

jreback commented Nov 23, 2018

can you merge master and update

@znicholls
Copy link
Contributor Author

We're working on a new release of Pint (hgrecco/pint#693) but none of us can find the time right now, I hope to in January

@datapythonista
Copy link
Member

CI is green now, is this ready to be merged, or are we waiting for the next Pint release?

@datapythonista
Copy link
Member

@znicholls is this ready to be merged? or is a new Pint release or something else needed?

@datapythonista datapythonista self-assigned this Dec 19, 2018
@znicholls
Copy link
Contributor Author

or is a new Pint release or something else needed?

Up to you guys. It will be included in the next Pint release but maybe best wait given we're still a bit uncertain about how best to do it (Panda's pytest test suite isn't playing nice with Pint's unittest test suite and we don't understand why, see hgrecco/pint#741)

@datapythonista
Copy link
Member

datapythonista commented Dec 19, 2018

Ok, I see. Thanks for the clarification. I'll then close this PR for now, but please ping us when you update Pint, so we reopen it and discuss any needed change then.

@znicholls
Copy link
Contributor Author

@datapythonista we have release pint-pandas on pypi (https://pypi.org/project/Pint-Pandas/). I've re-written the docs (see e.g. https://github.com/znicholls/pandas/blob/patch-1/doc/source/ecosystem.rst#pint-pandas) so can we re-open or make a new PR please?

FYI @hgrecco and @andrewgsavage

@datapythonista
Copy link
Member

GitHub doesn't let me reopen this PR, since the branch has been forced pushed or recreated. Can you open a new PR please?

Also, the ecosystem was moved to the website, it's a different file now.

Thanks for the work on this.

@znicholls
Copy link
Contributor Author

ok cool have made #35170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants