Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an example with / in namespace to README and SPEC #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 29, 2022

  1. add an example with / in namespace to README and SPEC

    I think it is not clear from the text in the README and the examples
    whether a `/` in the namespace needs to be escaped. This adds an example
    from `/test-suite-data.json` to the list of examples, to make that
    clear, that escaping should not be done.
    
    A follow-up question, that is not scope of this PR, would be:
    =============================================================
    given the PURL `pkg:swift/github.com%2FAlamofire/Alamofire@5.4.3`
    is `pkg:swift/github.com/Alamofire/Alamofire@5.4.3` its canonical form?
    If yes, it should be added to the test cases.
    
    Or, for having more fun and with looking at package-url#63 : what is the canonical
    form of `pkg:golang/github.com%2Frussross%2Fblackfriday%2Fv2@v2.1.0`?
    
    Signed-off-by: Maximilian Huber <gh@maxhbr.de>
    maxhbr committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    133e455 View commit details
    Browse the repository at this point in the history