add an example with / in namespace to README and SPEC
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is not clear from the text in the README and the examples whether a `/` in the namespace needs to be escaped. This adds an example from `/test-suite-data.json` to the list of examples, to make that clear, that escaping should not be done. A follow-up question, that is not scope of this PR, would be: ============================================================= given the PURL `pkg:swift/github.com%2FAlamofire/Alamofire@5.4.3` is `pkg:swift/github.com/Alamofire/Alamofire@5.4.3` its canonical form? If yes, it should be added to the test cases. Or, for having more fun and with looking at package-url#63 : what is the canonical form of `pkg:golang/github.com%2Frussross%2Fblackfriday%2Fv2@v2.1.0`? Signed-off-by: Maximilian Huber <gh@maxhbr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is not clear from the text in the README and the examples whether a
/in the namespace needs to be escaped. This adds an example from/test-suite-data.jsonto the list of examples, to make that clear, that escaping should not be done.A follow-up question, that is not scope of this PR, would be:
given the PURL
pkg:swift/github.com%2FAlamofire/Alamofire@5.4.3ispkg:swift/github.com/Alamofire/Alamofire@5.4.3its canonical form?If yes, it should be added to the test cases.
Or, for having more fun and with looking at #63 : what is the canonical form of
pkg:golang/github.com%2Frussross%2Fblackfriday%2Fv2@v2.1.0?