Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture the whole git tag as the version for GutHub URL in url2purl #159

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

tdruez
Copy link
Collaborator

@tdruez tdruez commented Jul 24, 2024

See aboutcode-org/dejacode#153
Capture the whole git tag as the version for GutHub URL in url2purl instead of adding a version_prefix qualifier.
Note that the version_prefix qualifier is still supported in purl2url for backward compatibility.

@tdruez tdruez requested a review from pombredanne July 24, 2024 16:20
pombredanne
pombredanne previously approved these changes Jul 24, 2024
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@pombredanne
Copy link
Member

For info:

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez tdruez merged commit dd33e2d into main Jul 24, 2024
7 of 38 checks passed
@tdruez tdruez deleted the version_prefix-removal branch July 24, 2024 17:00
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jul 28, 2024
0.15.6 (2024-07-25)
-------------------

- Refine support for GitHub /archive/refs/tags/ URLs in ``url2purl``.
  The whole tag is now captured as the version.
  This allows to properly reconstruct valid URLs in ``purl2url``.

0.15.5 (2024-07-24)
-------------------

- Capture the whole git tag as the version for GutHub URL in ``url2purl`` instead of
  adding a version_prefix qualifier.
  Note that the version_prefix qualifier is still supported in ``purl2url`` for
  backward compatibility.
  package-url/packageurl-python#159
jloehel added a commit to jloehel/packageurl-python that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants