Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version prefix? #14

Closed
pombredanne opened this issue Jul 24, 2024 · 1 comment
Closed

version prefix? #14

pombredanne opened this issue Jul 24, 2024 · 1 comment
Assignees
@giterlizzi

Comments

@pombredanne
Copy link

I see you are using a "version_prefix" qualifier for github/gitlab/bitbucket PURLs.
I guess you likely took that from the contrib/ folder in the packageurl-python library?

FYI, we are rolling that back there as it was a failed and fraught experiment: https://github.com/package-url/packageurl-python/pull/159/files

I would suggest you also roll this back. Instead just take a full tag as-is, unstripped
@pombredanne pombredanne mentioned this issue Jul 24, 2024
Merged
@giterlizzi giterlizzi self-assigned this Jul 24, 2024
giterlizzi added a commit that referenced this issue Jul 24, 2024
@giterlizzi
Dropped support for "version_prefix" qualifier for "github", "gitlab"…
99435dc 
… and "bitbucket" PURL types in "purl_to_urls" util

(#14)
@giterlizzi
Copy link
Owner

Thank you for your report. Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giterlizzi giterlizzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @giterlizzi