fix(syntax): correct is_reserved_keyword_or_global_object's incorrect function calling.
#4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
7086cmd
changed the title
is_reserved_keyword_or_global_object's incorrect function calling.is_reserved_keyword_or_global_object's incorrect function calling.
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Jul 26, 2024
Rolldown seems to panic when parsing the following JSON before this PR:
```json
{ "null": null }
```
I used functions in `oxc::syntax::keyword` to solve it.
Notice that `is_reserved_keyword_or_global_object` function is suffering
wrong calling (related pr: oxc-project/oxc#4484), I'll separately call
them in this PR.
7086cmd
changed the title
is_reserved_keyword_or_global_object's incorrect function calling.is_reserved_keyword_or_global_object's incorrect function calling.
CodSpeed Performance ReportMerging #4484 will not alter performanceComparing Summary
|
DonIsaac
approved these changes
Jul 26, 2024
|
@overlookmotel thanks for the heads up, I'll make a PR removing it tomorrow |
|
No worries. I already removed it, just wanted to let you know why. |
Merged
Dunqing
pushed a commit
that referenced
this pull request
Jul 28, 2024
## [0.22.1] - 2024-07-27 ### Features - 2477330 ast: Add `AstKind::TSExportAssignment` (#4501) (Dunqing) - aaee07e ast: Add `AstKind::AssignmentTargetPattern`, `AstKind::ArrayAssignmentTarget` and `AstKind::ObjectAssignmentTarget` (#4456) (Dunqing) - fd363d1 ast: Add AstKind::get_container_scope_id (#4450) (DonIsaac) - e2735ca span: Add `contains_inclusive` method (#4491) (DonIsaac) ### Bug Fixes - 368112c ast: Remove `#[visit(ignore)]` from `ExportDefaultDeclarationKind`'s `TSInterfaceDeclaration` (#4497) (Dunqing) - 36bb680 semantic: `TSExportAssignment` cannot reference type binding (#4502) (Dunqing) - cb2fa49 semantic: `typeof` operator cannot reference type-only import (#4500) (Dunqing) - ef0e953 semantic: Generic passed to typeof not counted as a reference (#4499) (Dunqing) - 40cafb8 semantic: Params in `export default (function() {})` flagged as `SymbolFlags::Export` (#4480) (Dunqing) - 2e01a45 semantic: Non-exported namespace member symbols flagged as exported (#4493) (Don Isaac) - e4ca06a semantic: Incorrect symbol’s scope_id after var hoisting (#4458) (Dunqing) - 77bd5f1 semantic: Use correct span for namespace symbols (#4448) (Don Isaac) - 5db7bed sourcemap: Fix pre-calculation of required segments for building JSON (#4490) (overlookmotel) - 1667491 syntax: Correct `is_reserved_keyword_or_global_object`'s incorrect function calling. (#4484) (Ethan Goh) - 82ba2a0 syntax: Fix unsound use of `NonZeroU32` (#4466) (overlookmotel) - c04b9aa transformer: Add to `SymbolTable::declarations` for all symbols (#4460) (overlookmotel) - ecdee88 transformer/typescript: Incorrect eliminate exports when the referenced symbol is both value and type (#4507) (Dunqing) ### Performance - 963a2d1 mangler: Reduce unnecessary allocation (#4498) (Dunqing) - 868fc87 parser: Optimize conditional advance on ASCII values (#4298) (lucab) - 24beaeb semantic: Give `AstNodeId` a niche (#4469) (overlookmotel) - 348c1ad semantic: Remove `span` field from `Reference` (#4464) (overlookmotel) - 6a9f4db semantic: Reduce storage size for symbol redeclarations (#4463) (overlookmotel) - 705e19f sourcemap: Reduce memory copies encoding JSON (#4489) (overlookmotel) - 4d10c6c sourcemap: Pre allocate String buf while encoding (#4476) (Brooooooklyn) ### Documentation - f5f0ba8 ast: Add doc comments to more AST nodes (#4413) (Don Isaac) - 871b3d6 semantic: Add doc comments for SymbolTester and SemanticTester (#4433) (DonIsaac) ### Refactor - 9c5d2f9 ast/builder: Use `Box::new_in` over `.into_in` (#4428) (overlookmotel) - ccb1835 semantic: Methods take `Span` as param, not `&Span` (#4470) (overlookmotel) - f17254a semantic: Populate `declarations` field in `SymbolTable::create_symbol` (#4461) (overlookmotel) - a49f491 semantic: Re-order `SymbolTable` fields (#4459) (overlookmotel) - 7cd53f3 semantic: Var hoisting (#4379) (Dunqing) - 4f5a7cb semantic: Mark SemanticTester and SymbolTester as must_use (#4430) (DonIsaac) - c958a55 sourcemap: `push_list` method for building JSON (#4486) (overlookmotel) - c99b3eb syntax: Give `ScopeId` a niche (#4468) (overlookmotel) - 96fc94f syntax: Use `NonMaxU32` for IDs (#4467) (overlookmotel) ### Testing - 4b274a8 semantic: Add more test cases for symbol references (#4429) (DonIsaac) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Sep 9, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@iconify-json/vscode-icons](https://icon-sets.iconify.design/vscode-icons/) | [`1.2.0` -> `1.2.1`](https://renovatebot.com/diffs/npm/@iconify-json%2fvscode-icons/1.2.0/1.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`22.5.2` -> `22.5.4`](https://renovatebot.com/diffs/npm/@types%2fnode/22.5.2/22.5.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [cjs-module-lexer](https://redirect.github.com/nodejs/cjs-module-lexer) | [`1.4.0` -> `1.4.1`](https://renovatebot.com/diffs/npm/cjs-module-lexer/1.4.0/1.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [debug](https://redirect.github.com/debug-js/debug) | [`4.3.6` -> `4.3.7`](https://renovatebot.com/diffs/npm/debug/4.3.6/4.3.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [follow-redirects](https://redirect.github.com/follow-redirects/follow-redirects) | [`1.15.6` -> `1.15.9`](https://renovatebot.com/diffs/npm/follow-redirects/1.15.6/1.15.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [npm-rolldown](https://rolldown.rs/) ([source](https://redirect.github.com/rolldown/rolldown/tree/HEAD/packages/rolldown)) | [`0.12.2` -> `0.13.2`](https://renovatebot.com/diffs/npm/npm-rolldown/0.12.2/0.13.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [oxlint](https://oxc.rs) ([source](https://redirect.github.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.9.2` -> `0.9.3`](https://renovatebot.com/diffs/npm/oxlint/0.9.2/0.9.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [remeda](https://remedajs.com/) ([source](https://redirect.github.com/remeda/remeda)) | [`2.11.0` -> `2.12.0`](https://renovatebot.com/diffs/npm/remeda/2.11.0/2.12.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [type-fest](https://redirect.github.com/sindresorhus/type-fest) | [`4.26.0` -> `4.26.1`](https://renovatebot.com/diffs/npm/type-fest/4.26.0/4.26.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vite](https://vitejs.dev) ([source](https://redirect.github.com/vitejs/vite/tree/HEAD/packages/vite)) | [`5.4.2` -> `5.4.3`](https://renovatebot.com/diffs/npm/vite/5.4.2/5.4.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vue](https://redirect.github.com/vuejs/core/tree/main/packages/vue#readme) ([source](https://redirect.github.com/vuejs/core)) | [`3.4.38` -> `3.5.3`](https://renovatebot.com/diffs/npm/vue/3.4.38/3.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nodejs/cjs-module-lexer (cjs-module-lexer)</summary> ### [`v1.4.1`](https://redirect.github.com/nodejs/cjs-module-lexer/compare/1.4.0...1.4.1) [Compare Source](https://redirect.github.com/nodejs/cjs-module-lexer/compare/1.4.0...1.4.1) </details> <details> <summary>debug-js/debug (debug)</summary> ### [`v4.3.7`](https://redirect.github.com/debug-js/debug/releases/tag/4.3.7) [Compare Source](https://redirect.github.com/debug-js/debug/compare/4.3.6...4.3.7) #### What's Changed - Upgrade ms to version 2.1.3 by [@​realityking](https://redirect.github.com/realityking) in [https://github.com/debug-js/debug/pull/819](https://redirect.github.com/debug-js/debug/pull/819) **Full Changelog**: https://github.com/debug-js/debug/compare/4.3.6...4.3.7 </details> <details> <summary>follow-redirects/follow-redirects (follow-redirects)</summary> ### [`v1.15.9`](https://redirect.github.com/follow-redirects/follow-redirects/compare/v1.15.8...v1.15.9) [Compare Source](https://redirect.github.com/follow-redirects/follow-redirects/compare/v1.15.8...v1.15.9) ### [`v1.15.8`](https://redirect.github.com/follow-redirects/follow-redirects/compare/v1.15.7...v1.15.8) [Compare Source](https://redirect.github.com/follow-redirects/follow-redirects/compare/v1.15.7...v1.15.8) ### [`v1.15.7`](https://redirect.github.com/follow-redirects/follow-redirects/compare/v1.15.6...v1.15.7) [Compare Source](https://redirect.github.com/follow-redirects/follow-redirects/compare/v1.15.6...v1.15.7) </details> <details> <summary>rolldown/rolldown (npm-rolldown)</summary> ### [`v0.13.2`](https://redirect.github.com/rolldown/rolldown/blob/HEAD/CHANGELOG.md#0132-2024-09-06) [Compare Source](https://redirect.github.com/rolldown/rolldown/compare/v0.13.1...v0.13.2) ##### Features - **node/advance-chunks:** support global fallback for `minSize`, `minShareCount` ([#​2178](https://redirect.github.com/rolldown/rolldown/issues/2178)) ([78c7750](https://redirect.github.com/rolldown/rolldown/commit/78c7750f186391d145f5b317a9ff6e5fbb2ba508)) - **node/advance-chunks:** support passing `minSize`, `minShareCount` ([#​2177](https://redirect.github.com/rolldown/rolldown/issues/2177)) ([3c95d30](https://redirect.github.com/rolldown/rolldown/commit/3c95d308a849ef6485410ef3248935198f3fcec0)) - **rust/advance-chunks:** support `min_share_count` option ([#​2176](https://redirect.github.com/rolldown/rolldown/issues/2176)) ([689cbc2](https://redirect.github.com/rolldown/rolldown/commit/689cbc23b43b3df99c9819d2a89911dcc80fac1b)) - **rust/advance-chunks:** support `min_size` option ([#​2175](https://redirect.github.com/rolldown/rolldown/issues/2175)) ([1e9c2d9](https://redirect.github.com/rolldown/rolldown/commit/1e9c2d9bf8195df869186f11a9c73539408ca067)) ### [`v0.13.1`](https://redirect.github.com/rolldown/rolldown/blob/HEAD/CHANGELOG.md#0131-2024-09-05) [Compare Source](https://redirect.github.com/rolldown/rolldown/compare/v0.13.0...v0.13.1) ##### Bug Fixes - `process.env.NODE_ENV` inside paren expr ([#​2153](https://redirect.github.com/rolldown/rolldown/issues/2153)) ([fddb2f5](https://redirect.github.com/rolldown/rolldown/commit/fddb2f58a52c79c30d83b9b1c542bb816df5ef49)) - 🐛 make `examples/rollup-plugin-esbuild` build successfully ([#​2164](https://redirect.github.com/rolldown/rolldown/issues/2164)) ([49f2d83](https://redirect.github.com/rolldown/rolldown/commit/49f2d8359069c96611aece143c602a4b9b1230d8)), closes [#​2163](https://redirect.github.com/rolldown/rolldown/issues/2163) - mark knownGlobals global ident and global member access as side effects free ([#​2154](https://redirect.github.com/rolldown/rolldown/issues/2154)) ([00ff45d](https://redirect.github.com/rolldown/rolldown/commit/00ff45dc7833cb8b0ad4dd6c526bb1acd50c8ad9)), closes [/github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/config/globals.go#L30-L850](https://redirect.github.com//github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/config/globals.go/issues/L30-L850) [/github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/config/globals.go#L940-L961](https://redirect.github.com//github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/config/globals.go/issues/L940-L961) - module type mapping ([#​2151](https://redirect.github.com/rolldown/rolldown/issues/2151)) ([c2e77b5](https://redirect.github.com/rolldown/rolldown/commit/c2e77b5aa5a64c03c397ce55e9bc0356426b9aad)) - **rolldown:** remove `console.log` ([#​2145](https://redirect.github.com/rolldown/rolldown/issues/2145)) ([d24c337](https://redirect.github.com/rolldown/rolldown/commit/d24c3371798831915a1c5ae51c49c5664dbf7d6a)) - **rolldown:** side effect detector mark `+1` `-1` as number literal ([#​2162](https://redirect.github.com/rolldown/rolldown/issues/2162)) ([40ae24d](https://redirect.github.com/rolldown/rolldown/commit/40ae24d59711599e8fb23ae5f3619144eb001cec)) ##### Features - **node/rolldown:** support `OutputOptions#advancedChunks` ([#​2167](https://redirect.github.com/rolldown/rolldown/issues/2167)) ([851475d](https://redirect.github.com/rolldown/rolldown/commit/851475d9d318ddab904d38eb6bfabc118d2707e8)) - **rust/advance-chunks:** A module could be catched by multiple match groups ([#​2155](https://redirect.github.com/rolldown/rolldown/issues/2155)) ([071efd8](https://redirect.github.com/rolldown/rolldown/commit/071efd83bc24148c4a8aadac287f7c150be0d88d)) - **rust/advance-chunks:** rework with new API deisgn ([#​2146](https://redirect.github.com/rolldown/rolldown/issues/2146)) ([6339062](https://redirect.github.com/rolldown/rolldown/commit/6339062a086570e6e5d6a3f6b8e4e13b379a3957)) - **rust/advance-chunks:** should include matched module's dependencies too ([#​2161](https://redirect.github.com/rolldown/rolldown/issues/2161)) ([a557b51](https://redirect.github.com/rolldown/rolldown/commit/a557b512605b5722a7653c5d27e75abbdd0e90ec)) - **rust/advance-chunks:** support `test` using regex ([#​2152](https://redirect.github.com/rolldown/rolldown/issues/2152)) ([b7b2ac5](https://redirect.github.com/rolldown/rolldown/commit/b7b2ac541145b9f974e049a9077df136eda34323)) ##### Performance Improvements - codegen in multiple chunks ([#​2122](https://redirect.github.com/rolldown/rolldown/issues/2122)) ([ee878c8](https://redirect.github.com/rolldown/rolldown/commit/ee878c8a97ce8841dc2bd9337da422752a683a71)) ### [`v0.13.0`](https://redirect.github.com/rolldown/rolldown/blob/HEAD/CHANGELOG.md#0130-2024-09-03) [Compare Source](https://redirect.github.com/rolldown/rolldown/compare/v0.12.2...v0.13.0) ##### Bug Fixes - incorrect point free function call ([#​1697](https://redirect.github.com/rolldown/rolldown/issues/1697)) ([4fb7ab6](https://redirect.github.com/rolldown/rolldown/commit/4fb7ab6c83ebd0195dcc99b63e1b73fb02ca3c00)) - JSON.parse() should not have side effect ([#​2029](https://redirect.github.com/rolldown/rolldown/issues/2029)) ([4ca169c](https://redirect.github.com/rolldown/rolldown/commit/4ca169ce74548b647c38cbcda6c2991b77a9d3c7)) - share replace global define config ([#​1902](https://redirect.github.com/rolldown/rolldown/issues/1902)) ([eee1db0](https://redirect.github.com/rolldown/rolldown/commit/eee1db08020c641bd56101a71f3714b501cd61b8)) - should not compose if there is only one pending plugin ([#​1781](https://redirect.github.com/rolldown/rolldown/issues/1781)) ([f3e4933](https://redirect.github.com/rolldown/rolldown/commit/f3e49330c5a5506d3aea5619569cb8d2cbae73d1)) - should not url encode when plain text ([#​1724](https://redirect.github.com/rolldown/rolldown/issues/1724)) ([779f16d](https://redirect.github.com/rolldown/rolldown/commit/779f16da869ad109451c1947487ebff6d40bd1d7)) - 🐛 auto guess module type when load hook no specify ([#​1930](https://redirect.github.com/rolldown/rolldown/issues/1930)) ([7d36481](https://redirect.github.com/rolldown/rolldown/commit/7d36481c75fdaa2d0b8c5e8d660f1d776f2d178d)) - Add namespace for each builtin plugin ([#​1931](https://redirect.github.com/rolldown/rolldown/issues/1931)) ([43f863b](https://redirect.github.com/rolldown/rolldown/commit/43f863b3c948e19b94ffeb18bf6e7ad6991b40c6)), closes [/github.com/rolldown/vite/blob/3bf86e3f715c952a032b476b60c8c869e9c50f3f/packages/vite/src/node/plugins/dynamicImportVars.ts#L174-L174](https://redirect.github.com//github.com/rolldown/vite/blob/3bf86e3f715c952a032b476b60c8c869e9c50f3f/packages/vite/src/node/plugins/dynamicImportVars.ts/issues/L174-L174) - Allowing gcc builds on windows ([#​2034](https://redirect.github.com/rolldown/rolldown/issues/2034)) ([e6b9f14](https://redirect.github.com/rolldown/rolldown/commit/e6b9f148b3e50a4db7ccf646e3d38c2dca607aaf)) - avoid panic if member expr referneced to non-namespace symbol ([#​1784](https://redirect.github.com/rolldown/rolldown/issues/1784)) ([3d30284](https://redirect.github.com/rolldown/rolldown/commit/3d3028452d77854a8cd596a5094d28b37d3ce2ba)) - avoid take first chunk if bundle is empty ([#​1887](https://redirect.github.com/rolldown/rolldown/issues/1887)) ([03f6dc9](https://redirect.github.com/rolldown/rolldown/commit/03f6dc99db5687719585e07c489f31dc7b861251)) - base64 handling ([#​1725](https://redirect.github.com/rolldown/rolldown/issues/1725)) ([af95809](https://redirect.github.com/rolldown/rolldown/commit/af95809fcdeb273b071b9cafb0f8f804ab7c911d)) - chained reexport star cjs ([#​2100](https://redirect.github.com/rolldown/rolldown/issues/2100)) ([04a8bba](https://redirect.github.com/rolldown/rolldown/commit/04a8bba32b1c5616ce85aa3e50c9fbb727d5eff5)) - circular ref in rolldown package bundle ([#​1849](https://redirect.github.com/rolldown/rolldown/issues/1849)) ([3c3cb83](https://redirect.github.com/rolldown/rolldown/commit/3c3cb8340bddc59cdceb51cd451651d97ed76e62)) - **cjs:** aovid generate assgin pattern if chunk imports nothing ([#​1959](https://redirect.github.com/rolldown/rolldown/issues/1959)) ([32c3363](https://redirect.github.com/rolldown/rolldown/commit/32c33631f2d99cc2ac72a2c4733bf9dae8970f5c)) - **cli:** `rolldown -c` should not print help messages ([#​1993](https://redirect.github.com/rolldown/rolldown/issues/1993)) ([a82ccc6](https://redirect.github.com/rolldown/rolldown/commit/a82ccc6a9bd733ee326d28e8b57f4240993c5436)) - **cli:** should not hang if error occured ([#​2035](https://redirect.github.com/rolldown/rolldown/issues/2035)) ([8e0cb61](https://redirect.github.com/rolldown/rolldown/commit/8e0cb613e4dd50b5f70a4a648ad72d243b80a432)), closes [#​2033](https://redirect.github.com/rolldown/rolldown/issues/2033) - collect depended_symbol when `canonical_ref` has `ns_alias` ([#​2095](https://redirect.github.com/rolldown/rolldown/issues/2095)) ([ab6b043](https://redirect.github.com/rolldown/rolldown/commit/ab6b0434da24f814edf3becc42dd63557beea87e)), closes [#​2079](https://redirect.github.com/rolldown/rolldown/issues/2079) - collect-dependends-symbol ([#​2079](https://redirect.github.com/rolldown/rolldown/issues/2079)) ([0205983](https://redirect.github.com/rolldown/rolldown/commit/02059832b3cce75498fb19ccfe6f9537421dd057)), closes [#​2038](https://redirect.github.com/rolldown/rolldown/issues/2038) - dedup export all external in entry module ([#​1786](https://redirect.github.com/rolldown/rolldown/issues/1786)) ([3eba8a3](https://redirect.github.com/rolldown/rolldown/commit/3eba8a33042f27bb3077f3c0c873a8c7caf71911)) - ensure ordering of assign chunk name ([#​1981](https://redirect.github.com/rolldown/rolldown/issues/1981)) ([7ac1381](https://redirect.github.com/rolldown/rolldown/commit/7ac138156b3c303ca184cc33264251dedcae9b32)) - ensure referenced symbols by entry point chunk got deconflicted ([#​2094](https://redirect.github.com/rolldown/rolldown/issues/2094)) ([dc98faa](https://redirect.github.com/rolldown/rolldown/commit/dc98faa6248c9b5391acc79df2da6ec1212960fe)), closes [#​1722](https://redirect.github.com/rolldown/rolldown/issues/1722) [#​2085](https://redirect.github.com/rolldown/rolldown/issues/2085) - entry chunk should be at first ([#​2089](https://redirect.github.com/rolldown/rolldown/issues/2089)) ([8b7734e](https://redirect.github.com/rolldown/rolldown/commit/8b7734e56ec2e8ea2fca4ff55d782c74d6049ffe)) - eval warning should only emit when used as callExpr ([#​2054](https://redirect.github.com/rolldown/rolldown/issues/2054)) ([e350abe](https://redirect.github.com/rolldown/rolldown/commit/e350abe0bd5ea6961b58b2d558f343aaf8390bf7)) - **experimental:** wrong `transform` behavior after composing ([#​1701](https://redirect.github.com/rolldown/rolldown/issues/1701)) ([3a1f216](https://redirect.github.com/rolldown/rolldown/commit/3a1f216be0065b531649c8ae01192d542cde1a92)) - external module side effects should respect hook returned side e… ([#​2068](https://redirect.github.com/rolldown/rolldown/issues/2068)) ([0f9391b](https://redirect.github.com/rolldown/rolldown/commit/0f9391b9ac6b65bbe1aebf045d45d74a604772a2)) - fix `absolute_preliminary_filename` not taking `options.cwd` into account ([#​1935](https://redirect.github.com/rolldown/rolldown/issues/1935)) ([6b6d713](https://redirect.github.com/rolldown/rolldown/commit/6b6d71304610d2f7985f05f05623b39fe7bcaed2)) - **foramt/cjs:** preserve semantic of entries exports even in wrapped ([#​1788](https://redirect.github.com/rolldown/rolldown/issues/1788)) ([b79e7e0](https://redirect.github.com/rolldown/rolldown/commit/b79e7e0a1bb75d4270b4cd7076c214796807f9ee)) - **format/cjs:** exported bindings should be lived. Part1 ([#​1791](https://redirect.github.com/rolldown/rolldown/issues/1791)) ([17ca21d](https://redirect.github.com/rolldown/rolldown/commit/17ca21daf7c0f80c9bd5ccdf546092dfc7d08625)) - **format/cjs:** should keep live bindings for common chunks ([#​1805](https://redirect.github.com/rolldown/rolldown/issues/1805)) ([145f105](https://redirect.github.com/rolldown/rolldown/commit/145f1052d4ad89029843050a14674fe676077881)) - **format/cjs:** support `cjs-module-lexer` for `export * from 'external'` ([#​1854](https://redirect.github.com/rolldown/rolldown/issues/1854)) ([de1f5f5](https://redirect.github.com/rolldown/rolldown/commit/de1f5f580be4ed74d964d54b745c75c387980659)) - generate valid file name for virtual module chunk ([#​1782](https://redirect.github.com/rolldown/rolldown/issues/1782)) ([d041e08](https://redirect.github.com/rolldown/rolldown/commit/d041e08abc340c573196c9df05d073e7bb0ca665)) - guessing module type ([#​2086](https://redirect.github.com/rolldown/rolldown/issues/2086)) ([aa5b528](https://redirect.github.com/rolldown/rolldown/commit/aa5b528a3fca6679abfe6c9c051291d5026bebb2)) - index_cross_chunk_imports should including share chunk ([#​1890](https://redirect.github.com/rolldown/rolldown/issues/1890)) ([290ecc7](https://redirect.github.com/rolldown/rolldown/commit/290ecc703e7896106a0cc0a391b2bbf869cfe4bd)) - move `banner` ahead of the file in `cjs` format. ([#​1707](https://redirect.github.com/rolldown/rolldown/issues/1707)) ([2640072](https://redirect.github.com/rolldown/rolldown/commit/2640072c9edd83ade6ece5da7599a686cc5fa5e4)), closes [#​1706](https://redirect.github.com/rolldown/rolldown/issues/1706) [#​1705](https://redirect.github.com/rolldown/rolldown/issues/1705) [/github.com/rolldown/rolldown/pull/1705#discussion_r1689236056](https://redirect.github.com//github.com/rolldown/rolldown/pull/1705/issues/discussion_r1689236056) - **node/compose-plugins:** Plugin that uses `order` meta is considered as not composable ([#​1943](https://redirect.github.com/rolldown/rolldown/issues/1943)) ([ebfebf3](https://redirect.github.com/rolldown/rolldown/commit/ebfebf30d3bfea4d8c9034b09e9032752d332ad7)) - **node/composePlugins:** ensure correct semantic of `PluginContext#resolveId` of all hooks ([#​2050](https://redirect.github.com/rolldown/rolldown/issues/2050)) ([f19b6c7](https://redirect.github.com/rolldown/rolldown/commit/f19b6c78fdfa22d6c54b2d46dc3043dd0e75a1d6)) - **node/plugin:** ensure order for generateBundle and writeBundle hooks ([#​1913](https://redirect.github.com/rolldown/rolldown/issues/1913)) ([b7e1d90](https://redirect.github.com/rolldown/rolldown/commit/b7e1d9064aee5d585bc205755351a2dce4b3052c)) - **node/rolldown:** mark all tsfn as weak to avoid long exit time ([#​2135](https://redirect.github.com/rolldown/rolldown/issues/2135)) ([06b578c](https://redirect.github.com/rolldown/rolldown/commit/06b578c04491db1d2eb840bccaa1091f85f449a0)), closes [/github.com/rolldown/rolldown/pull/985#issuecomment-2081384205](https://redirect.github.com//github.com/rolldown/rolldown/pull/985/issues/issuecomment-2081384205) - **packages/rolldown:** export `package.json` ([#​2048](https://redirect.github.com/rolldown/rolldown/issues/2048)) ([5aa76dc](https://redirect.github.com/rolldown/rolldown/commit/5aa76dc6f3421373bb5053c34743ec5a4a99e1c1)) - pass `output.globals` to Rust side. ([#​1912](https://redirect.github.com/rolldown/rolldown/issues/1912)) ([bd84267](https://redirect.github.com/rolldown/rolldown/commit/bd8426723869a271363efed6550928b76c2131a4)) - perform percent encoding to reserved chars in dataurl. ([#​1729](https://redirect.github.com/rolldown/rolldown/issues/1729)) ([d75e77c](https://redirect.github.com/rolldown/rolldown/commit/d75e77c4520218131c2561250774a2644427c9e2)), closes [#​1406](https://redirect.github.com/rolldown/rolldown/issues/1406) [/datatracker.ietf.org/doc/html/rfc3986#section-2](https://redirect.github.com//datatracker.ietf.org/doc/html/rfc3986/issues/section-2) - **plugin/replace:** handle backtrack limit exceeded error ([#​2088](https://redirect.github.com/rolldown/rolldown/issues/2088)) ([33fca46](https://redirect.github.com/rolldown/rolldown/commit/33fca46a353afa47d0f35b0a723622e167ec97de)), closes [/github.com/rolldown/rolldown/pull/2056#issuecomment-2316570663](https://redirect.github.com//github.com/rolldown/rolldown/pull/2056/issues/issuecomment-2316570663) - remove name assignment in IIFE that doesn't have export. ([#​1900](https://redirect.github.com/rolldown/rolldown/issues/1900)) ([13f4adc](https://redirect.github.com/rolldown/rolldown/commit/13f4adc8b1a2bc26591a25df6aef14fe855f8fa5)) - remove napi deferred_trace feature ([#​2018](https://redirect.github.com/rolldown/rolldown/issues/2018)) ([b99f74e](https://redirect.github.com/rolldown/rolldown/commit/b99f74ef66b45664ca18f6e2b5b3444259ac220d)) - remove redundant code in `export * from 'external'` for esm format ([#​1974](https://redirect.github.com/rolldown/rolldown/issues/1974)) ([2eb06ef](https://redirect.github.com/rolldown/rolldown/commit/2eb06ef40cc19fb69bde2f9dece41479260e3fd2)) - remove ts expect error ([#​1817](https://redirect.github.com/rolldown/rolldown/issues/1817)) ([3153a61](https://redirect.github.com/rolldown/rolldown/commit/3153a614c9dab13d655fdebd51bd51f6b520a1c8)), closes [#​1811](https://redirect.github.com/rolldown/rolldown/issues/1811) - reserve `reserved-key` in json module type. ([#​1746](https://redirect.github.com/rolldown/rolldown/issues/1746)) ([7243165](https://redirect.github.com/rolldown/rolldown/commit/72431654b3eccccac78d0ca60d3516a11af5a165)), closes [oxc-project/oxc#4484](https://redirect.github.com/oxc-project/oxc/issues/4484) - resolve conflict `exports` key in `CJS` and `IIFE`. ([#​1837](https://redirect.github.com/rolldown/rolldown/issues/1837)) ([2953b90](https://redirect.github.com/rolldown/rolldown/commit/2953b9023450639a5450ac94d9ba666c04ae86ae)), closes [#​1836](https://redirect.github.com/rolldown/rolldown/issues/1836) [#​1623](https://redirect.github.com/rolldown/rolldown/issues/1623) [/github.com/rolldown/rolldown/pull/1694#issuecomment-2245219042](https://redirect.github.com//github.com/rolldown/rolldown/pull/1694/issues/issuecomment-2245219042) [#​1623](https://redirect.github.com/rolldown/rolldown/issues/1623) - **rolldown:** fix inject test where `alias` can be a member expression ([#​1934](https://redirect.github.com/rolldown/rolldown/issues/1934)) ([c5aafad](https://redirect.github.com/rolldown/rolldown/commit/c5aafadfa5704cbe679bf6fb68e1810d08a642a3)), closes [/github.com/rollup/plugins/blob/8550c4b1925b246adbd3af48ed0e5f74f822c951/packages/inject/src/index.js#L125](https://redirect.github.com//github.com/rollup/plugins/blob/8550c4b1925b246adbd3af48ed0e5f74f822c951/packages/inject/src/index.js/issues/L125) - **rolldown:** should correct rewrite path of dynamic imported external modules ([#​1738](https://redirect.github.com/rolldown/rolldown/issues/1738)) ([c682b76](https://redirect.github.com/rolldown/rolldown/commit/c682b76d214bd50711c8e8c6ffd1acb1a4b2e17f)), closes [#​1723](https://redirect.github.com/rolldown/rolldown/issues/1723) - **rust/rolldown:** prevent segment fault in `generate_bundle` by removing unsafe code ([#​1905](https://redirect.github.com/rolldown/rolldown/issues/1905)) ([9802478](https://redirect.github.com/rolldown/rolldown/commit/98024783c9f09475a537c05db9b722cbc9c4193b)) - same filenames cause bundle error ([#​1984](https://redirect.github.com/rolldown/rolldown/issues/1984)) ([c4aca98](https://redirect.github.com/rolldown/rolldown/commit/c4aca984a910503273e4b2435fa13f8c5a68023c)), closes [#​1944](https://redirect.github.com/rolldown/rolldown/issues/1944) [/github.com/rolldown/rolldown/issues/1944#issuecomment-2282812102](https://redirect.github.com//github.com/rolldown/rolldown/issues/1944/issues/issuecomment-2282812102) - should also care for `Chunk#name` for common chunks ([#​2123](https://redirect.github.com/rolldown/rolldown/issues/2123)) ([a1fa701](https://redirect.github.com/rolldown/rolldown/commit/a1fa701403452ee520e94aa3b5780a40c507b5de)) - should call write_bundle after write bundle to disk ([#​1844](https://redirect.github.com/rolldown/rolldown/issues/1844)) ([475f765](https://redirect.github.com/rolldown/rolldown/commit/475f765931876081825badd4f63420ae0a90634d)), closes [/github.com/rollup/rollup/blob/master/src/rollup/rollup.ts#L194-L200](https://redirect.github.com//github.com/rollup/rollup/blob/master/src/rollup/rollup.ts/issues/L194-L200) - should correctly include symbols of namespace object ([#​1727](https://redirect.github.com/rolldown/rolldown/issues/1727)) ([3dee9e0](https://redirect.github.com/rolldown/rolldown/commit/3dee9e01b9ebb7b1fb205967f9942d7c4c22c35c)) - should generate `export * from ...` in entry chunks rather than entry modules ([#​1783](https://redirect.github.com/rolldown/rolldown/issues/1783)) ([954dd2a](https://redirect.github.com/rolldown/rolldown/commit/954dd2a5fa5988ad0ea587d1d73d4a6e915ad56a)) - should not panic if there are accessing on `star as` member ([#​1730](https://redirect.github.com/rolldown/rolldown/issues/1730)) ([250c11a](https://redirect.github.com/rolldown/rolldown/commit/250c11a541d34485fbd7b0c1420e10a830d822c4)) - sourcemap inline url should relative to asset file ([#​2099](https://redirect.github.com/rolldown/rolldown/issues/2099)) ([6b5d7dc](https://redirect.github.com/rolldown/rolldown/commit/6b5d7dc97b47895bd8280d29c2a815e159fa6b8c)) - strict emit warning `commonjs var in esm` ([#​2101](https://redirect.github.com/rolldown/rolldown/issues/2101)) ([4c9feeb](https://redirect.github.com/rolldown/rolldown/commit/4c9feeb058f0212228e430450004967c99af9177)), closes [/esbuild.github.io/try/#YgAwLjIzLjEALS1idW5kbGUgLS1taW5pZnk9ZmFsc2UgLS1mb3JtYXQ9ZXNtAGUAZW50cnkuanMALyoqIERldGVjdCBmcmVlIHZhcmlhYmxlIGBleHBvcnRzYC4gKi8KdmFyIGZyZWVFeHBvcnRzID0gdHlwZW9mIGV4cG9ydHMgPT0gJ29iamVjdCcgJiYgZXhwb3J0cyAmJiAhZXhwb3J0cy5ub2RlVHlwZSAmJiBleHBvcnRzOwoKLyoqIERldGVjdCBmcmVlIHZhcmlhYmxlIGBtb2R1bGVgLiAqLwp2YXIgZnJlZU1vZHVsZSA9IGZyZWVFeHBvcnRzICYmIHR5cGVvZiBtb2R1bGUuZXhwb3J0cyA9PSAnb2JqZWN0JyAmJiBtb2R1bGUgJiYgIW1vZHVsZS5ub2RlVHlwZSAmJiBtb2R1bGU7CgovKiogRGV0ZWN0IHRoZSBwb3B1bGFyIENvbW1vbkpTIGV4dGVuc2lvbiBgbW9kdWxlLmV4cG9ydHNgLiAqLwp2YXIgbW9kdWxlRXhwb3J0cyA9IGZyZWVNb2R1bGUgJiYgZnJlZU1vZHVsZS5leHBvcnRzID09PSBmcmVlRXhwb3J0czsKCi8qKiBCdWlsdC1pbiB2YWx1ZSByZWZlcmVuY2VzLiAqLwp2YXIgQnVmZmVyID0gbW9kdWxlRXhwb3J0](https://redirect.github.com//esbuild.github.io/try//issues/YgAwLjIzLjEALS1idW5kbGUgLS1taW5pZnk9ZmFsc2UgLS1mb3JtYXQ9ZXNtAGUAZW50cnkuanMALyoqIERldGVjdCBmcmVlIHZhcmlhYmxlIGBleHBvcnRzYC4gKi8KdmFyIGZyZWVFeHBvcnRzID0gdHlwZW9mIGV4cG9ydHMgPT0gJ29iamVjdCcgJiYgZXhwb3J0cyAmJiAhZXhwb3J0cy5ub2RlVHlwZSAmJiBleHBvcnRzOwoKLyoqIERldGVjdCBmcmVlIHZhcmlhYmxlIGBtb2R1bGVgLiAqLwp2YXIgZnJlZU1vZHVsZSA9IGZyZWVFeHBvcnRzICYmIHR5cGVvZiBtb2R1bGUuZXhwb3J0cyA9PSAnb2JqZWN0JyAmJiBtb2R1bGUgJiYgIW1vZHVsZS5ub2RlVHlwZSAmJiBtb2R1bGU7CgovKiogRGV0ZWN0IHRoZSBwb3B1bGFyIENvbW1vbkpTIGV4dGVuc2lvbiBgbW9kdWxlLmV4cG9ydHNgLiAqLwp2YXIgbW9kdWxlRXhwb3J0cyA9IGZyZWVNb2R1bGUgJiYgZnJlZU1vZHVsZS5leHBvcnRzID09PSBmcmVlRXhwb3J0czsKCi8qKiBCdWlsdC1pbiB2YWx1ZSByZWZlcmVuY2VzLiAqLwp2YXIgQnVmZmVyID0gbW9kdWxlRXhwb3J0) - **treeshaking:** `require` should consider as having side effects ([#​1949](https://redirect.github.com/rolldown/rolldown/issues/1949)) ([28e53d6](https://redirect.github.com/rolldown/rolldown/commit/28e53d6b8582728e6dbb6a45a0cea47b87f7c004)) - typo of `transform-plugin-context.ts` ([#​1991](https://redirect.github.com/rolldown/rolldown/issues/1991)) ([b2590fd](https://redirect.github.com/rolldown/rolldown/commit/b2590fd4a0b9643a5b6c956b2fa6d662d782a4cf)) - undefined export var ([#​2055](https://redirect.github.com/rolldown/rolldown/issues/2055)) ([6832084](https://redirect.github.com/rolldown/rolldown/commit/6832084b7cd69daed9144ba365813bd3f280075c)), closes [/github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/js_parser/js_parser.go#L10047-L10050](https://redirect.github.com//github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/js_parser/js_parser.go/issues/L10047-L10050) - using sanitize_file_name to generate valid file name ([#​1833](https://redirect.github.com/rolldown/rolldown/issues/1833)) ([c9f8af4](https://redirect.github.com/rolldown/rolldown/commit/c9f8af403fa17316f1a1c0f9c5ad437b417f74e1)) ##### Features - add dynamic_import_vars plugin ([#​1732](https://redirect.github.com/rolldown/rolldown/issues/1732)) ([40cf58b](https://redirect.github.com/rolldown/rolldown/commit/40cf58b9bb8b3f9d7145d97c25308213b68e2260)) - add invalid export option to generate diagnostic ([#​1692](https://redirect.github.com/rolldown/rolldown/issues/1692)) ([ef718d7](https://redirect.github.com/rolldown/rolldown/commit/ef718d76dc143b1183a6e1f78f3a51b9b24cded0)) - add LoadOutput#ModuleType binding ([#​1998](https://redirect.github.com/rolldown/rolldown/issues/1998)) ([1469985](https://redirect.github.com/rolldown/rolldown/commit/1469985c3649053bc3334a0f945b06e61ecda39e)) - add manifest plugin ([#​1839](https://redirect.github.com/rolldown/rolldown/issues/1839)) ([8288370](https://redirect.github.com/rolldown/rolldown/commit/8288370c3904c79fffaff6fd024c61c69cfc0f79)), closes [#​1826](https://redirect.github.com/rolldown/rolldown/issues/1826) - add module type to transform hook ([#​1907](https://redirect.github.com/rolldown/rolldown/issues/1907)) ([159a155](https://redirect.github.com/rolldown/rolldown/commit/159a1559bc5204418317614426f303d87b5ae408)) - add module_preload_polyfill plugin ([#​1840](https://redirect.github.com/rolldown/rolldown/issues/1840)) ([0651db0](https://redirect.github.com/rolldown/rolldown/commit/0651db0f0ac14e104bc15898d73f8e34cf64c4f3)) - add originalFileName to EmittedAsset ([#​2046](https://redirect.github.com/rolldown/rolldown/issues/2046)) ([6facb04](https://redirect.github.com/rolldown/rolldown/commit/6facb04bc22f6966bb934812f89c7d4b2288458a)) - add query after each glob file name ([#​1838](https://redirect.github.com/rolldown/rolldown/issues/1838)) ([bd97d60](https://redirect.github.com/rolldown/rolldown/commit/bd97d60ef581e3bd2aaf576a0aa6910161db3489)) - add some warnings in IIFE and CJS. ([#​1857](https://redirect.github.com/rolldown/rolldown/issues/1857)) ([e7916ab](https://redirect.github.com/rolldown/rolldown/commit/e7916ab69eda952a98d8624a365e60a514e1e322)), closes [#​1855](https://redirect.github.com/rolldown/rolldown/issues/1855) - add support for banner as str ([#​1810](https://redirect.github.com/rolldown/rolldown/issues/1810)) ([12d6a75](https://redirect.github.com/rolldown/rolldown/commit/12d6a756bd9279298f1f2e1298693c47d2a255a6)) - add support for footer as str ([#​1819](https://redirect.github.com/rolldown/rolldown/issues/1819)) ([48dc08e](https://redirect.github.com/rolldown/rolldown/commit/48dc08ec3bc69517a9fb3419f56d1a8a8b056b5c)) - add support for intro as str ([#​1820](https://redirect.github.com/rolldown/rolldown/issues/1820)) ([2c7e4f4](https://redirect.github.com/rolldown/rolldown/commit/2c7e4f4b5751965372efa5bdf48e56b9c23dc507)) - add support for outro as str ([#​1821](https://redirect.github.com/rolldown/rolldown/issues/1821)) ([46d56c4](https://redirect.github.com/rolldown/rolldown/commit/46d56c48b13eedf6f2e2f92cc6063e0debdee592)) - add use strict for iife ([#​1705](https://redirect.github.com/rolldown/rolldown/issues/1705)) ([abe17bd](https://redirect.github.com/rolldown/rolldown/commit/abe17bdd3e9a8fb54f95c6d0074e60751d11c25e)) - add wasm fallback plugin ([#​1957](https://redirect.github.com/rolldown/rolldown/issues/1957)) ([3645f38](https://redirect.github.com/rolldown/rolldown/commit/3645f38014b06e5db80f87091f3d4d3cf4ffd41e)), closes [#​1919](https://redirect.github.com/rolldown/rolldown/issues/1919) - alias plugin ([#​2001](https://redirect.github.com/rolldown/rolldown/issues/2001)) ([872bf3a](https://redirect.github.com/rolldown/rolldown/commit/872bf3addb3db766649f28e43e9613a134daa2ca)), closes [/github.com/rolldown/vite/blob/c1d60d11158318ae8ccaef873b6dc55d0a2f3c66/packages/vite/src/node/plugins/index.ts#L62-L65](https://redirect.github.com//github.com/rolldown/vite/blob/c1d60d11158318ae8ccaef873b6dc55d0a2f3c66/packages/vite/src/node/plugins/index.ts/issues/L62-L65) - align cli options with unix ux patterns. ([#​1977](https://redirect.github.com/rolldown/rolldown/issues/1977)) ([c820678](https://redirect.github.com/rolldown/rolldown/commit/c8206787d038bb469f9797a1cd24db934f8c77a3)), closes [#​1924](https://redirect.github.com/rolldown/rolldown/issues/1924) - align generated chunk name with rollup ([#​2124](https://redirect.github.com/rolldown/rolldown/issues/2124)) ([0bec3bc](https://redirect.github.com/rolldown/rolldown/commit/0bec3bc9ac80aa3b51cd711b17e737a7a3f1b5ff)) - align OutputOptions#esModule with rollup ([#​1898](https://redirect.github.com/rolldown/rolldown/issues/1898)) ([c14406f](https://redirect.github.com/rolldown/rolldown/commit/c14406fb61051cba19833368a23539a4342c8e80)), closes [#​1888](https://redirect.github.com/rolldown/rolldown/issues/1888) [/github.com/rolldown/rolldown/blob/e0751e4db539ce8e25ca8f31bb027475a0dd9e98/crates/rolldown_binding/src/options/binding_output_options/mod.rs#L37-L38](https://redirect.github.com//github.com/rolldown/rolldown/blob/e0751e4db539ce8e25ca8f31bb027475a0dd9e98/crates/rolldown_binding/src/options/binding_output_options/mod.rs/issues/L37-L38) - allow passing array of array in `config.plugins` ([#​1938](https://redirect.github.com/rolldown/rolldown/issues/1938)) ([b4e33d5](https://redirect.github.com/rolldown/rolldown/commit/b4e33d5e1a1138491631f6b83047dac62f54ddce)) - allow rewrite `moduleType` in transform Hook ([#​1916](https://redirect.github.com/rolldown/rolldown/issues/1916)) ([cef3e57](https://redirect.github.com/rolldown/rolldown/commit/cef3e576aa2c7b09cb4cdf2bf1b5ab41ffa31887)) - assignment expr side effect detector ([#​2004](https://redirect.github.com/rolldown/rolldown/issues/2004)) ([dde9b33](https://redirect.github.com/rolldown/rolldown/commit/dde9b33b409bfc909d089769d2817f178e00f30f)) - build import analysis plugin ([#​2051](https://redirect.github.com/rolldown/rolldown/issues/2051)) ([9e461c2](https://redirect.github.com/rolldown/rolldown/commit/9e461c2cc21ce8094b3c20fb19a7a97da377502e)) - commonjs-variable-in-esm diagnostic ([#​1832](https://redirect.github.com/rolldown/rolldown/issues/1832)) ([ffd4533](https://redirect.github.com/rolldown/rolldown/commit/ffd453328ceb75331be56eedfc09e66150c495aa)), closes [/github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md#01411](https://redirect.github.com//github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md/issues/01411) - compose addon hooks ([#​2007](https://redirect.github.com/rolldown/rolldown/issues/2007)) ([08b6360](https://redirect.github.com/rolldown/rolldown/commit/08b6360b6e9e08b731ae7e6948ef67fc5b991c92)), closes [#​1999](https://redirect.github.com/rolldown/rolldown/issues/1999) - **css/wip:** add `css_entry_filenames` and `css_chunk_filenames` ([#​1678](https://redirect.github.com/rolldown/rolldown/issues/1678)) ([bc1c22e](https://redirect.github.com/rolldown/rolldown/commit/bc1c22ec5a7666b22e7709914cbafb3dc20d13f1)) - enable plugin api typing ([#​1765](https://redirect.github.com/rolldown/rolldown/issues/1765)) ([512fc61](https://redirect.github.com/rolldown/rolldown/commit/512fc6156a83655dae6a7c1939411cae93ed3d69)) - **error:** entry cannot be external ([#​1761](https://redirect.github.com/rolldown/rolldown/issues/1761)) ([b3179e7](https://redirect.github.com/rolldown/rolldown/commit/b3179e70dfa5130e4cdeaa67da67886c413536c6)) - **experimental:** builtin replace plugin ([#​2056](https://redirect.github.com/rolldown/rolldown/issues/2056)) ([f1e7ed0](https://redirect.github.com/rolldown/rolldown/commit/f1e7ed05fbee66e5d7ee761716bfa9345b2cceb6)) - **experimental:** support `enableComposingJsPlugins` option ([#​1693](https://redirect.github.com/rolldown/rolldown/issues/1693)) ([7aa56fe](https://redirect.github.com/rolldown/rolldown/commit/7aa56fea466220c0158d2c4b9d41f0220ed7fed0)) - gracefully shutdown the process when panic in `fetch_all_modules` ([#​2036](https://redirect.github.com/rolldown/rolldown/issues/2036)) ([c85883b](https://redirect.github.com/rolldown/rolldown/commit/c85883bb5a2ff8631d318816ef186ce5e7e723bd)), closes [#​2033](https://redirect.github.com/rolldown/rolldown/issues/2033) [/github.com/rolldown/rolldown/blob/8e0cb613e4dd50b5f70a4a648ad72d243b80a432/crates/rolldown/src/module_loader/module_loader.rs#L286-L288](https://redirect.github.com//github.com/rolldown/rolldown/blob/8e0cb613e4dd50b5f70a4a648ad72d243b80a432/crates/rolldown/src/module_loader/module_loader.rs/issues/L286-L288) [/github.com/rolldown/rolldown/blob/8e0cb613e4dd50b5f70a4a648ad72d243b80a432/crates/rolldown/src/module_loader/module_task.rs#L60-L62](https://redirect.github.com//github.com/rolldown/rolldown/blob/8e0cb613e4dd50b5f70a4a648ad72d243b80a432/crates/rolldown/src/module_loader/module_task.rs/issues/L60-L62) - hook filter ([#​2047](https://redirect.github.com/rolldown/rolldown/issues/2047)) ([6039415](https://redirect.github.com/rolldown/rolldown/commit/60394157439658f0a105828bc0cf016bb490c816)) - implement the rest branches in side effect detector ([#​2009](https://redirect.github.com/rolldown/rolldown/issues/2009)) ([ef084bf](https://redirect.github.com/rolldown/rolldown/commit/ef084bf154b89ee4a65702dd0b46a4c9bdbcd159)) - import build analysis builtUrl ([#​2075](https://redirect.github.com/rolldown/rolldown/issues/2075)) ([0cf4345](https://redirect.github.com/rolldown/rolldown/commit/0cf43452e7885ab3e9af43edb4090fd252102db8)), closes [/github.com/rolldown/vite/blob/56476ffabc182eb7bb735c192156069f52838956/packages/vite/src/node/plugins/importAnalysisBuild.ts#L346-L350](https://redirect.github.com//github.com/rolldown/vite/blob/56476ffabc182eb7bb735c192156069f52838956/packages/vite/src/node/plugins/importAnalysisBuild.ts/issues/L346-L350) - improve resolve error ([#​2076](https://redirect.github.com/rolldown/rolldown/issues/2076)) ([ea4965f](https://redirect.github.com/rolldown/rolldown/commit/ea4965f7db76797b44041ee9fb79b3c5b58e50db)), closes [#​2033](https://redirect.github.com/rolldown/rolldown/issues/2033) - json plugin ([#​1951](https://redirect.github.com/rolldown/rolldown/issues/1951)) ([d221ecc](https://redirect.github.com/rolldown/rolldown/commit/d221eccdba70e7a504fc726efcf4de1be243caa3)) - load fallback plugin ([#​1922](https://redirect.github.com/rolldown/rolldown/issues/1922)) ([3ea6797](https://redirect.github.com/rolldown/rolldown/commit/3ea679734e75fec50dc33064fbc43531e4ff0b24)) - module preload config skip ([#​1845](https://redirect.github.com/rolldown/rolldown/issues/1845)) ([f55cfda](https://redirect.github.com/rolldown/rolldown/commit/f55cfda1cdb2d17c6c914261d410d3f95d5e867b)) - **node/composingJsPlugins:** support `resolveId` hook ([#​2021](https://redirect.github.com/rolldown/rolldown/issues/2021)) ([55c20b0](https://redirect.github.com/rolldown/rolldown/commit/55c20b09f4298d96fbbc83657abf9cb7095407dd)) - **node/rolldown:** add empty `PluginContext#addWatchFile` for shim ([#​1972](https://redirect.github.com/rolldown/rolldown/issues/1972)) ([559b424](https://redirect.github.com/rolldown/rolldown/commit/559b42478ed51215203b2db08ca171f27db722a1)) - **node/rolldown:** support `define` functionality ([#​1891](https://redirect.github.com/rolldown/rolldown/issues/1891)) ([43f6f22](https://redirect.github.com/rolldown/rolldown/commit/43f6f225e41a38df233eb4174fb5c03ff2e577b4)), closes [#​186](https://redirect.github.com/rolldown/rolldown/issues/186) - **node/rolldown:** support `InputOptions#inject` ([#​1946](https://redirect.github.com/rolldown/rolldown/issues/1946)) ([9071d6a](https://redirect.github.com/rolldown/rolldown/commit/9071d6a40832aad4fe3392b46c150b8cdfc45893)) - **node:** support CLI options. ([#​1963](https://redirect.github.com/rolldown/rolldown/issues/1963)) ([6d4ef7e](https://redirect.github.com/rolldown/rolldown/commit/6d4ef7efda3e4f24a0e9b95c830f7c5f02bb80f0)), closes [#​1955](https://redirect.github.com/rolldown/rolldown/issues/1955) - **node:** support passing `custom` in `PluginContext#resolve` ([#​1874](https://redirect.github.com/rolldown/rolldown/issues/1874)) ([6a61bad](https://redirect.github.com/rolldown/rolldown/commit/6a61bad94feebcdf99c7b98b1e8336adc9c15dd4)), closes [/github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/resolve.ts#L181](https://redirect.github.com//github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/resolve.ts/issues/L181) - **packages/rolldown:** export `VERSION` ([#​2049](https://redirect.github.com/rolldown/rolldown/issues/2049)) ([806718d](https://redirect.github.com/rolldown/rolldown/commit/806718de1565efc5907abcc0e93bd8f7da30d3d8)), closes [/github.com/rollup/rollup/blob/3eb88175f687193e8a73e681dc1fbd6bd48201a2/src/node-entry.ts#L1](https://redirect.github.com//github.com/rollup/rollup/blob/3eb88175f687193e8a73e681dc1fbd6bd48201a2/src/node-entry.ts/issues/L1) - **plugin/replace:** objectGuards ([#​2121](https://redirect.github.com/rolldown/rolldown/issues/2121)) ([ea76b06](https://redirect.github.com/rolldown/rolldown/commit/ea76b061ebcaa64bdb96c7056b51d2f6ff9d0615)), closes [#​2057](https://redirect.github.com/rolldown/rolldown/issues/2057) [1#L46](https://redirect.github.com/1/issues/L46) [/github.com/rollup/plugins/blob/master/packages/replace/src/index.js#L41](https://redirect.github.com//github.com/rollup/plugins/blob/master/packages/replace/src/index.js/issues/L41) - **plugin/replace:** prevent assignment ([#​2093](https://redirect.github.com/rolldown/rolldown/issues/2093)) ([18ac29c](https://redirect.github.com/rolldown/rolldown/commit/18ac29ca0d6997a74ca457f917daaae3f7773036)), closes [#​2057](https://redirect.github.com/rolldown/rolldown/issues/2057) [/github.com/rollup/plugins/blob/master/packages/replace/src/index.js#L77-L82](https://redirect.github.com//github.com/rollup/plugins/blob/master/packages/replace/src/index.js/issues/L77-L82) - provide more friendly diagnostics if could not read path from a resolveId hook ([#​1866](https://redirect.github.com/rolldown/rolldown/issues/1866)) ([690a63f](https://redirect.github.com/rolldown/rolldown/commit/690a63f7aacbf9bd57d3fb305f9acb3524d0c92e)), closes [#​1851](https://redirect.github.com/rolldown/rolldown/issues/1851) - **rolldown_ecmascript:** implement into_assignment_target ObjectPattern ([#​1921](https://redirect.github.com/rolldown/rolldown/issues/1921)) ([305f7cb](https://redirect.github.com/rolldown/rolldown/commit/305f7cb596639cad073fdb76670ec59b1df44007)), closes [/github.com/rolldown/rolldown/blob/13f4adc8b1a2bc26591a25df6aef14fe855f8fa5/crates/rolldown_ecmascript/src/ext/mod.rs#L61-L63](https://redirect.github.com//github.com/rolldown/rolldown/blob/13f4adc8b1a2bc26591a25df6aef14fe855f8fa5/crates/rolldown_ecmascript/src/ext/mod.rs/issues/L61-L63) - **rolldown:** bump oxc to v0.25.0 ([#​2042](https://redirect.github.com/rolldown/rolldown/issues/2042)) ([71d8201](https://redirect.github.com/rolldown/rolldown/commit/71d820145db7d4494849d2092fa521d78f50167c)) - **rust/plugin:** Support `custom` in `PluginContextResolveOptions` ([#​1876](https://redirect.github.com/rolldown/rolldown/issues/1876)) ([0c6cae4](https://redirect.github.com/rolldown/rolldown/commit/0c6cae4b236d7afc05e5a5ef92a61b1d382a4c0d)), closes [#​1874](https://redirect.github.com/rolldown/rolldown/issues/1874) - **rust/rolldown:** support `inject` imports ([#​1933](https://redirect.github.com/rolldown/rolldown/issues/1933)) ([a2bb2ca](https://redirect.github.com/rolldown/rolldown/commit/a2bb2cae97e0f79f712c8ff68d116366ee4ecf35)) - **rust:** ensure consistency between scanned top-level symbols and scope's ([#​1742](https://redirect.github.com/rolldown/rolldown/issues/1742)) ([00d43e9](https://redirect.github.com/rolldown/rolldown/commit/00d43e9a4a78789ced5722153fd5112c7ed75b19)) - **rust:** ensure span uniqueness of oxc AST ([#​1927](https://redirect.github.com/rolldown/rolldown/issues/1927)) ([9f164c6](https://redirect.github.com/rolldown/rolldown/commit/9f164c69af4370d60c5c18a89837e759e71202a4)), closes [/github.com/rolldown/rolldown/pull/1899#issuecomment-2274936578](https://redirect.github.com//github.com/rolldown/rolldown/pull/1899/issues/issuecomment-2274936578) - **rust:** support `advanced_chunks` option ([#​2115](https://redirect.github.com/rolldown/rolldown/issues/2115)) ([1a81db2](https://redirect.github.com/rolldown/rolldown/commit/1a81db2f979d54e8b3bd145ab8850a8df3ac8ef9)) - **rust:** support `define` functionality ([#​1882](https://redirect.github.com/rolldown/rolldown/issues/1882)) ([8639e70](https://redirect.github.com/rolldown/rolldown/commit/8639e704e07eeba932b2df4f23c8a18d9b865eba)) - support `intro` and `outro` in plugins. ([#​1763](https://redirect.github.com/rolldown/rolldown/issues/1763)) ([b15d8c5](https://redirect.github.com/rolldown/rolldown/commit/b15d8c5d19c5f90860b99a3dde92173e8d8cf822)), closes [#​1755](https://redirect.github.com/rolldown/rolldown/issues/1755) [#​1713](https://redirect.github.com/rolldown/rolldown/issues/1713) - support `output.esModule` option ([#​1812](https://redirect.github.com/rolldown/rolldown/issues/1812)) ([4999aed](https://redirect.github.com/rolldown/rolldown/commit/4999aed32c6fb66b8cf87af855b3992b902c5d76)) - support `output.exports` for `IIFE` format align with rollup. ([#​1691](https://redirect.github.com/rolldown/rolldown/issues/1691)) ([5418e1f](https://redirect.github.com/rolldown/rolldown/commit/5418e1f18910e08a68460038295fd0b4989a14cb)), closes [#​1680](https://redirect.github.com/rolldown/rolldown/issues/1680) - support `output.footer` in plugins. ([#​1713](https://redirect.github.com/rolldown/rolldown/issues/1713)) ([536d5f7](https://redirect.github.com/rolldown/rolldown/commit/536d5f71fd53b61bdde1b6b92868a81d9f5f3278)), closes [#​1702](https://redirect.github.com/rolldown/rolldown/issues/1702) [/github.com/rolldown/rolldown/pull/1702#issuecomment-2248059655](https://redirect.github.com//github.com/rolldown/rolldown/pull/1702/issues/issuecomment-2248059655) - support `output.globals` for iife format ([#​1694](https://redirect.github.com/rolldown/rolldown/issues/1694)) ([8aad7d0](https://redirect.github.com/rolldown/rolldown/commit/8aad7d0fc33c4ca991352b86362b0c0fa383944c)), closes [#​1623](https://redirect.github.com/rolldown/rolldown/issues/1623) [#​1569](https://redirect.github.com/rolldown/rolldown/issues/1569) - support `output.inlineDynamicImports` option. ([#​2081](https://redirect.github.com/rolldown/rolldown/issues/2081)) ([63b932e](https://redirect.github.com/rolldown/rolldown/commit/63b932ee7ebfcf45b79a1a02b2f4f456cedb10ff)), closes [#​1841](https://redirect.github.com/rolldown/rolldown/issues/1841) - support `output.intro` and `output.outro`. ([#​1712](https://redirect.github.com/rolldown/rolldown/issues/1712)) ([964c5ee](https://redirect.github.com/rolldown/rolldown/commit/964c5ee3a60a1784a68baf6ce47aaad8cd2b2a6f)), closes [#​819](https://redirect.github.com/rolldown/rolldown/issues/819) - support `OutputOptions#externalLiveBindings` ([#​1979](https://redirect.github.com/rolldown/rolldown/issues/1979)) ([cc41c94](https://redirect.github.com/rolldown/rolldown/commit/cc41c949e4003d6f7ae6a8b0f205111298a5a7c5)) - support `skipSelf` option in `PluginContext.resolve` ([#​1703](https://redirect.github.com/rolldown/rolldown/issues/1703)) ([a18a8da](https://redirect.github.com/rolldown/rolldown/commit/a18a8dafed5e156452ec0b5cf4934ba445c2da3b)), closes [#​1554](https://redirect.github.com/rolldown/rolldown/issues/1554) [#​819](https://redirect.github.com/rolldown/rolldown/issues/819) [/github.com/rollup/rollup/blob/28546b5821efcb72c2eb05f422d986524647a0e3/src/utils/PluginContext.ts#L78](https://redirect.github.com//github.com/rollup/rollup/blob/28546b5821efcb72c2eb05f422d986524647a0e3/src/utils/PluginContext.ts/issues/L78) - support flag for regex in plugin transform ([#​1969](https://redirect.github.com/rolldown/rolldown/issues/1969)) ([f4f6b49](https://redirect.github.com/rolldown/rolldown/commit/f4f6b49b3e316ff9588bf8176dae208cbc32ae0f)), closes [#​1914](https://redirect.github.com/rolldown/rolldown/issues/1914) [#​1915](https://redirect.github.com/rolldown/rolldown/issues/1915) [/github.com/rolldown/rolldown/blob/6389d62f876a122df451d3e0151f79f59dd978cb/crates/rolldown_plugin_transform/src/lib.rs#L20-L25](https://redirect.github.com//github.com/rolldown/rolldown/blob/6389d62f876a122df451d3e0151f79f59dd978cb/crates/rolldown_plugin_transform/src/lib.rs/issues/L20-L25) - support flags for hybrid regex ([#​1915](https://redirect.github.com/rolldown/rolldown/issues/1915)) ([5ad5820](https://redirect.github.com/rolldown/rolldown/commit/5ad5820c60f5788d5a70e89f83245909d68e3494)), closes [#​1911](https://redirect.github.com/rolldown/rolldown/issues/1911) - support function for entry/chunkFileNames ([#​1834](https://redirect.github.com/rolldown/rolldown/issues/1834)) ([d023f2f](https://redirect.github.com/rolldown/rolldown/commit/d023f2f95d604a3ab2ce0d627795fc8a3b77bd99)) - support loading dataurl as module. ([#​1741](https://redirect.github.com/rolldown/rolldown/issues/1741)) ([549e1e1](https://redirect.github.com/rolldown/rolldown/commit/549e1e1945b1dddad53598de7674f61800e45c4b)), closes [/github.com/evanw/esbuild/blob/main/internal/bundler_tests/snapshots/snapshots_loader.txt#L602](https://redirect.github.com//github.com/evanw/esbuild/blob/main/internal/bundler_tests/snapshots/snapshots_loader.txt/issues/L602) - support namespaced name and `output.extend` for IIFE format. ([#​1861](https://redirect.github.com/rolldown/rolldown/issues/1861)) ([bfae17d](https://redirect.github.com/rolldown/rolldown/commit/bfae17d8b9db4623df70a31ed224e7438501ed4e)) - support plugin order ([#​1929](https://redirect.github.com/rolldown/rolldown/issues/1929)) ([d128866](https://redirect.github.com/rolldown/rolldown/commit/d128866e72b1965831fe29d6e26187323417904d)) - transform plugin ([#​1914](https://redirect.github.com/rolldown/rolldown/issues/1914)) ([d37079a](https://redirect.github.com/rolldown/rolldown/commit/d37079a8b8c1b02416572088b7603b4e238c2aed)) - **tree-shake:** treeshake unused cjs module ([#​1744](https://redirect.github.com/rolldown/rolldown/issues/1744)) ([138dd25](https://redirect.github.com/rolldown/rolldown/commit/138dd257fc56e4a376ebff8bdb978517d17e2e91)) - **treeshaking:** only reference `__reExport` if needed ([#​1987](https://redirect.github.com/rolldown/rolldown/issues/1987)) ([4cac925](https://redirect.github.com/rolldown/rolldown/commit/4cac925d9964de917dfb6599437a40ad01635864)) - upgrade oxc ([#​1823](https://redirect.github.com/rolldown/rolldown/issues/1823)) ([540ee47](https://redirect.github.com/rolldown/rolldown/commit/540ee470aa3becc1eae1e1912b0f13d14a2c4b5f)) ##### Performance Improvements - ⚡️ reduce lock contention ([#​2072](https://redirect.github.com/rolldown/rolldown/issues/2072)) ([80dc48d](https://redirect.github.com/rolldown/rolldown/commit/80dc48d73b544a835292e0a2e6beede072c709be)) - ⚡️ remove extra collection when using rayon ([#​2016](https://redirect.github.com/rolldown/rolldown/issues/2016)) ([7442d95](https://redirect.github.com/rolldown/rolldown/commit/7442d956d545b59b4680f6982cec10d672110533)) - ⚡️ use base64-simd to accelerate calc base64 ([#​1716](https://redirect.github.com/rolldown/rolldown/issues/1716)) ([30b6d0f](https://redirect.git </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10am on monday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rolldown/rolldown). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Sep 12, 2024
<!-- Thank you for contributing! --> ### Description 1. follow todo, see oxc-project/oxc#4484 <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be a problem, but doesn't matter previously.
Formerly, the
is_reserved_keyword_or_global_objectisis_reserved_keyword(s) || is_reserved_keyword(s). I think it should beis_reserved_keyword(s) || is_global_object(s)according to its name.Also, the
.ideamay be because I am using RustRover, which may automatically create.ideafolder. So I ignore it in.gitignore.I think I can contribute to
oxcmore when I am free.