fix(transformer/typescript): incorrect eliminate exports when the ref…

…erenced symbol is both value and type (#4507)
oxc-project · Jul 27, 2024 · ecdee88 · ecdee88
1 parent 963a2d1
commit ecdee88
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/crates/oxc_transformer/src/typescript/annotations.rs b/crates/oxc_transformer/src/typescript/annotations.rs
@@ -87,7 +87,7 @@ impl<'a> TypeScriptAnnotations<'a> {
                                         ident.reference_id.get().is_some_and(|id| {
                                             ctx.symbols().references[id].symbol_id().is_some_and(
                                                 |symbol_id| {
-                                                    ctx.symbols().get_flag(symbol_id).is_type()
+                                                    !ctx.symbols().get_flag(symbol_id).is_value()
                                                 },
                                             )
                                         })

diff --git a/...cript/test/fixtures/class-export/input.ts → ...test/fixtures/export-elimination/input.ts b/...cript/test/fixtures/class-export/input.ts → ...test/fixtures/export-elimination/input.ts
@@ -8,4 +8,10 @@ namespace Name {
   export const Q = 0;
 }
 
-export { Im, Ok, Foo, Bar, Func, Baz, Baq, Name };
+export { Im, Ok, Foo, Bar, Func, Baz, Baq, Name };
+
+type T = number;
+function T(): T {
+  return 123;
+}
+export { T }
diff --git a/...ript/test/fixtures/class-export/output.ts → ...est/fixtures/export-elimination/output.ts b/...ript/test/fixtures/class-export/output.ts → ...est/fixtures/export-elimination/output.ts
@@ -6,4 +6,10 @@ let Name;
 (function(_Name) {
 	const Q = _Name.Q = 0;
 })(Name || (Name = {}));
+
 export { Im, Ok, Foo, Bar, Func, Name };
+
+function T() {
+	return 123;
+}
+export { T }