Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'uploadDataDuringCreation' option when uploading via tus #7111

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Use 'uploadDataDuringCreation' option when uploading via tus #7111

merged 4 commits into from
Jun 13, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jun 10, 2022 •
edited
Loading

Description

Uploading via tus now uses the uploadDataDuringCreation option which saves up one request. Also, we've fixed a serialization error during uploads, saving up another request.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jun 10, 2022
@JammingBen JammingBen mentioned this pull request Jun 10, 2022
Closed
@owncloud owncloud deleted a comment from update-docs bot Jun 10, 2022
@JammingBen JammingBen marked this pull request as ready for review June 13, 2022 08:07
@JammingBen JammingBen requested a review from kulmann June 13, 2022 08:07
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jun 13, 2022
@JammingBen JammingBen requested a review from kulmann June 13, 2022 08:33
@JammingBen JammingBen marked this pull request as draft June 13, 2022 08:38
kulmann
kulmann approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/26156/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26156/tracing/unstructured-collection-of-testable-space-interactions-alice-2022-6-13-08-46-58.zip

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

69.6% 69.6% Coverage
0.0% 0.0% Duplication

@kulmann kulmann marked this pull request as ready for review June 13, 2022 12:03
@kulmann kulmann merged commit e732532 into master Jun 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the upload-data-during-creation branch June 13, 2022 12:10
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @ownclouders @kulmann