Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload-overlay is slow and not robust #7066

Closed
tbsbdr opened this issue May 30, 2022 · 4 comments · Fixed by #7127
Closed

Upload-overlay is slow and not robust #7066

tbsbdr opened this issue May 30, 2022 · 4 comments · Fixed by #7127
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented May 30, 2022

Steps to reproduce

  1. Download und unpack Linux Kernel 5.17.8 : https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-5.17.8.tar.xz
  2. Login to https://ocis.ocis-wopi.released.owncloud.works/
  3. select "Upload" > "Folder" "linux-5.17.8/arch/arm64" (1.741 items, 12.75 MB)
  4. wait until List "XX uploads completed" shows up
  5. XX counts up and gets slower until it stops completely.
2022-05-30_11-15-27.mp4

Expected behaviour

  • upload overlay should not stop working for upload of many files (> 1.000 files). Please stresstest with linux-kernel files (Note: final goal is, that the upload of the whole linux kernel should be possible with 1.1 GB and ~80.000 files)
  • Simple overlay that tells me if the upload is
    • In progress
    • Completed
    • Failed
  • possibility to show details of the upload

Simple overlay:

image

Details overlay

The scribble shows

  • progress per single file
  • cancel per single file
    --> both info would be nice to have, but are costly to implement. So @JammingBen and I discussed to tackle this nice-to-have not within this ticket.
    --> Details-Scribble is subject to change until we know how to tackle the performance issue in the upload process.

image

Simplified time format

  • upload estimation time should be simplified (rounded)
  • mocks show a proposal - imo can be adapted if rounding-functions already exist

image

Actual behaviour

  • upload overlay stops working if many files are getting uploaded.
@tbsbdr tbsbdr added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels May 30, 2022
@JammingBen JammingBen self-assigned this May 30, 2022
@tbsbdr
Copy link
Contributor Author

tbsbdr commented May 31, 2022

@JammingBen any new insights where the performance bottle necks are? If yes, we should talk about what solution we can provide with cost/benefits in mind.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented May 31, 2022

@JammingBen in the scribble i used a "counter-clockwise" orientated arrow but noticed now in your draft, that this is confusing.
i google "retry icon" and most icons are clockwise orientated - I recommend to use the "restart" icon from remixicons for the retry-action:
image

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jun 7, 2022

added "Simplified time format" to initial comment

@JammingBen
Copy link
Collaborator

JammingBen commented Jun 10, 2022

Things have gotten a lot better with the recent updates, uploading the Linux Kernel is still not possible though. Next steps towards this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants