Skip to content

Commit

Permalink
Remove route storage usage, add changelog item
Browse files Browse the repository at this point in the history
  • Loading branch information
JammingBen committed Jun 10, 2022
1 parent fb2d088 commit ed4e7e0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
6 changes: 6 additions & 0 deletions changelog/unreleased/enhancement-upload-data-during-creation
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Upload data during creation

Uploading via tus now uses the `uploadDataDuringCreation` option which saves up one request. Also, we've fixed a serialization error during uploads, saving up another request.

https://github.com/owncloud/web/pull/7111
https://github.com/owncloud/web/issues/7066
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ export default defineComponent({
const uploadSizeSpaceMapping = uppyResources.reduce((acc, uppyResource) => {
let targetUploadSpace
if (uppyResource.meta.routeStorage === 'home') {
if (uppyResource.meta.routeName === 'files-spaces-personal') {
targetUploadSpace = this.spaces.find((space) => space.driveType === 'personal')
} else {
targetUploadSpace = this.spaces.find(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ describe('CreateAndUpload component', () => {
size: 1001
},
meta: {
routeStorage: 'home'
routeName: 'files-spaces-personal'
}
}
])
Expand Down
1 change: 0 additions & 1 deletion packages/web-runtime/src/components/UploadInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,6 @@ export default {
query: targetRoute.query,
params: {
...(storageId && path && { storageId }),
...(targetRoute.params?.storage && { storage: targetRoute.params?.storage }),
...(targetRoute.params?.shareName && { shareName: targetRoute.params?.shareName })
}
}
Expand Down

0 comments on commit ed4e7e0

Please sign in to comment.