-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style fixes for menus #6762
Style fixes for menus #6762
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@pascalwengerter @fschade @tbsbdr In contextActions I see menuSections() implementation, in "New" the separator is broder-bottom of the folder item, which is in our opinion inconsistent. Would it make sense from your point of view to implement menu sections for "New" menu as well?
|
Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/24870/29/1 💥 The acceptance tests pipeline failed. The build has been cancelled. |
6019b74
to
17aa818
Compare
thanks for your patience! thumbs up for the grouping, hover effects and housekeeping! |
Hey @elizavetaRa I've create a release candidate after your ODS PR has been merged. Could you please bump ODS to v13.1.0-rc.9 in this PR? Thanks :-) |
@kulmann rebased with latest master + bump ods + changelog. Let us know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
SonarCloud Quality Gate failed. |
Description
Related Issue
Fixes hover menus issues from #6555
Motivation and Context
More consistency in style of different menus
Screenshots (if appropriate):
Types of changes
Checklist: