Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes for menus #6762

Merged
merged 12 commits into from
Jun 2, 2022
Merged

Style fixes for menus #6762

merged 12 commits into from
Jun 2, 2022

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Apr 8, 2022

Description

Related Issue

Fixes hover menus issues from #6555

Motivation and Context

More consistency in style of different menus

Screenshots (if appropriate):

menus

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa
Copy link
Member Author

@pascalwengerter @fschade @tbsbdr In contextActions I see menuSections() implementation, in "New" the separator is broder-bottom of the folder item, which is in our opinion inconsistent.

Would it make sense from your point of view to implement menu sections for "New" menu as well?
I would propose the following sections:

  • folder
  • files, grouped by their origin app (MS Office, Open Office etc) if there is more than one file for the app. (example: Word Document, Excel Spreadsheet, PowerPoint slides in one section)
  • All other files in one section

@ownclouders
Copy link
Contributor

ownclouders commented Apr 22, 2022

Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/24870/29/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsToRootEdgeCases-shareWithGroupsEdgeCases_feature-L37.png

webUISharingInternalGroupsToRootEdgeCases-shareWithGroupsEdgeCases_feature-L37.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@diocas
Copy link
Contributor

diocas commented May 18, 2022

@tbsbdr
Copy link
Contributor

tbsbdr commented May 20, 2022

thanks for your patience! thumbs up for the grouping, hover effects and housekeeping!
@pascalwengerter any objections?
But still I would rate it with Prio3 .

@kulmann
Copy link
Member

kulmann commented Jun 2, 2022

Hey @elizavetaRa I've create a release candidate after your ODS PR has been merged. Could you please bump ODS to v13.1.0-rc.9 in this PR? Thanks :-)

@diocas
Copy link
Contributor

diocas commented Jun 2, 2022

@kulmann rebased with latest master + bump ods + changelog. Let us know if you need anything else.

@kulmann kulmann mentioned this pull request Jun 2, 2022
9 tasks
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.8% 68.8% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 4afcc75 into owncloud:master Jun 2, 2022
@diocas diocas deleted the menus branch June 2, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants