Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Style fixes for menus #2069

Merged
merged 9 commits into from
Jun 2, 2022
Merged

Style fixes for menus #2069

merged 9 commits into from
Jun 2, 2022

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Apr 8, 2022

Description

  • moving hover effect for tippy-box implemented in web to ods: adding hovers on "New" menus
  • unifying spacings for tippy-box menus
  • web part: Style fixes for menus web#6762

Related Issue

Fixes hover menus issues from owncloud/web#6555

Motivation and Context

More consistency in style of different menus:

Screenshots (if appropriate):

menus

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Apr 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa elizavetaRa marked this pull request as draft April 8, 2022 11:30
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing changelog items for the added icons (and would expect them to follow our naming convention for resource-type icons), also it seems that most of them aren't included in the mapping?

@elizavetaRa
Copy link
Member Author

elizavetaRa commented Apr 8, 2022

I'm missing changelog items for the added icons (and would expect them to follow our naming convention for resource-type icons), also it seems that most of them aren't included in the mapping?

I move icons to another issue&pr.

Hover Issues that will be fixed by this pr & pr in web are discussed in Design polishing v3, should I create a separate issue for them?

@elizavetaRa elizavetaRa marked this pull request as ready for review April 12, 2022 13:37
src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue Outdated Show resolved Hide resolved
src/components/atoms/OcDrop/OcDrop.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a changelog item would be needed 👍🏼

Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 rebase needed ^^

@diocas
Copy link

diocas commented May 18, 2022

@lookacat @pascalwengerter I guess this is ready to be merged?

src/components/atoms/OcDrop/OcDrop.vue Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann dismissed pascalwengerter’s stale review June 2, 2022 07:04

icons have been removed from the PR (reason for request for changes)

@kulmann kulmann merged commit 1944e76 into owncloud:master Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants