Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Style fixes for menus #2069

Merged
merged 9 commits into from
Jun 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/enhancement-hover-in-oc-drop-menues
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Hover in ocDrop menues

We've added the "oc-menu-item-hover" class for <li> elements inside ocDrop, to add the hover effect on buttons and links.

https://github.com/owncloud/owncloud-design-system/pull/2069
21 changes: 21 additions & 0 deletions src/components/atoms/OcDrop/OcDrop.vue
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,27 @@ export default {
// note: needed so that the box shadow from `oc-box-shadow-medium` doesn't get suppressed
padding: 8px;
}
li.oc-menu-item-hover {
a,
button:not([role="switch"]) {
box-sizing: border-box;
padding: var(--oc-space-small);
color: var(--oc-color-swatch-passive-default);
&:focus,
&:hover {
background-color: var(--oc-color-background-hover);

text-decoration: none !important;
border-radius: 5px;
}
&:hover span {
color: var(--oc-color-swatch-brand-hover) !important;
}
span {
text-decoration: none !important;
}
}
}
}

.oc-drop {
Expand Down
4 changes: 0 additions & 4 deletions src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,6 @@ export default {
#oc-breadcrumb-contextmenu-trigger > span {
vertical-align: middle;
border: 3px solid transparent;
&:hover {
background-color: var(--oc-color-background-hover);
border-radius: 5px;
}
}

#oc-breadcrumb-contextmenu li button {
Expand Down
2 changes: 1 addition & 1 deletion src/components/molecules/OcTable/OcTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ export default {
transition: background-color $transition-duration-short ease-in-out;
}

&-hover tr:hover span:not(.avatarInitials):not(button span) {
&-hover tr:hover td:not(:last-child) span:not(.avatarInitials):not(button span) {
color: var(--oc-color-swatch-brand-hover) !important;
}

Expand Down