Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes for menus: ContextDrop #6800

Closed
wants to merge 4 commits into from

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Apr 21, 2022

Description

  • moving hover effect to ContextDrop component
  • unifying spacings

Related Issue

Fixes hover menus issues from #6555

Motivation and Context

More consistency in style of different menus:

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

menus

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Apr 21, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elizavetaRa elizavetaRa force-pushed the upstream_menus branch 2 times, most recently from f5cecbe to f261371 Compare April 21, 2022 15:11
@kulmann
Copy link
Member

kulmann commented Jun 2, 2022

Is this PR still needed when #6762 gets merged?

@elizavetaRa elizavetaRa closed this Jun 3, 2022
@elizavetaRa elizavetaRa deleted the upstream_menus branch June 3, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants