Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to open file sidebar from permalink #265

Closed
PVince81 opened this issue Jul 31, 2018 · 17 comments · Fixed by owncloud/core#35101 or #1228
Closed

Link to open file sidebar from permalink #265

PVince81 opened this issue Jul 31, 2018 · 17 comments · Fixed by owncloud/core#35101 or #1228
Assignees
Milestone

Comments

@PVince81
Copy link
Contributor

"http://host/owncloud/f/$fileId?details=$tabId"

This will open the files app, scroll down to the file as before then automatically open the sidebar with the given tab id.

From owncloud/core#32152

cc @DeepDiver1975

@michaelstingl I think you requested something like this for clients so they could link to the versions panel directly. For the versions panel, replace $tabId with "versionsTabView"

@phil-davis
Copy link
Contributor

The currently valid values of tabId are:

commentsTabView
shareTabView
versionsTabView

@PVince81
Copy link
Contributor Author

@pmaier1 FYI ^

@settermjd
Copy link
Contributor

@pmaier1, can you give your feedback, please?

@settermjd settermjd transferred this issue from owncloud-archive/documentation Nov 19, 2018
@settermjd
Copy link
Contributor

ping @pmaier1

@pmaier1
Copy link
Contributor

pmaier1 commented Apr 8, 2019

@pmaier1, can you give your feedback, please?

Not sure what to give feedback on. I think this is something for the dev docs. Regular users will not use this. Rather it can be used for e.g. context menu options in the desktop client.

@michaelstingl
Copy link
Contributor

@michaelstingl I think you requested something like this for clients so they could link to the versions panel directly. For the versions panel, replace $tabId with "versionsTabView"

👍

@michaelstingl
Copy link
Contributor

@michaelstingl I think you requested something like this for clients so they could link to the versions panel directly. For the versions panel, replace $tabId with "versionsTabView"

@PVince81 @pmaier1 What server version will support this? Is there a capability for the clients to check if this is supported?

@PVince81
Copy link
Contributor Author

@karakayasemi mind taking care of adding a capabilities entry for the files app that advertises support for this ?

@PVince81 PVince81 added this to the Backlog milestone Apr 18, 2019
@PVince81
Copy link
Contributor Author

for the record: this parrameter exists since 10.0.10.

we'll add a capability nonetheless

@PVince81
Copy link
Contributor Author

capability will be in 10.2

@karakayasemi
Copy link
Contributor

@PVince81 If nothing left for me, I am removing my assignment in here?

@karakayasemi karakayasemi removed their assignment Apr 26, 2019
@micbar micbar modified the milestones: Development, Backlog May 6, 2019
@micbar
Copy link
Contributor

micbar commented May 13, 2019

@michaelstingl @pmaier1 Is there anything left open in this ticket?
Documentation?

@michaelstingl
Copy link
Contributor

@settermjd I can't find a docs-PR linking to this issue? Already done?

@micbar micbar modified the milestones: Backlog, Development May 19, 2019
@settermjd
Copy link
Contributor

@michaelstingl, not yet. I've only started documenting it today. Next question; is this only to be backported to 10.2?

@settermjd
Copy link
Contributor

After reading the acceptance tests, this looks straight-forward enough to me.

settermjd added a commit that referenced this issue May 20, 2019
This fixes #265 and relates to
owncloud/core#32152. It details the ability to
open one of three file sidebars (versions, comments, and shares) by
using a permalink.
@michaelstingl
Copy link
Contributor

is this only to be backported to 10.2?

@settermjd yeah, 10.2+

@settermjd
Copy link
Contributor

Thanks, @michaelstingl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment