Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ability to open the file sidebar from a permalink #1228

Merged
merged 9 commits into from
May 28, 2019
Merged

Document ability to open the file sidebar from a permalink #1228

merged 9 commits into from
May 28, 2019

Conversation

settermjd
Copy link
Contributor

@settermjd settermjd commented May 20, 2019 •
edited
Loading

This fixes #265 and relates to owncloud/core#32152. It details the ability to open one of three file sidebars (versions, comments, and shares) by using a permalink. I wasn't quite sure where to document this feature. The three locations that it has been documented in this PR seemed the best places (at least so far).

💁‍♂ Only backport to 10.2.

@settermjd
Document ability to open the file sidebar from a permalink
6d1fdb6 
This fixes #265 and relates to
owncloud/core#32152. It details the ability to
open one of three file sidebars (versions, comments, and shares) by
using a permalink.
@settermjd settermjd self-assigned this May 20, 2019
@michaelstingl michaelstingl mentioned this pull request May 20, 2019
Closed
michaelstingl
michaelstingl suggested changes May 22, 2019
View reviewed changes
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a new capability for it. Otherwise it doesn't make sense for the clients. Capability docs are super outdated, but we could add at least the new ones…

@settermjd
Copy link
Contributor Author

@michaelstingl, can you provide a description of the new capability pls?

@michaelstingl
Copy link
Contributor

@michaelstingl, can you provide a description of the new capability pls?

sure: owncloud/core#35104

@settermjd settermjd added the p3-medium Normal priority label May 27, 2019
@settermjd
Copy link
Contributor Author

@michaelstingl, do you just need the new capability added to https://doc.owncloud.com/server/developer_manual/core/ocs-capabilities.html#available-capabilities?

@michaelstingl
Copy link
Contributor

@michaelstingl, do you just need the new capability added to https://doc.owncloud.com/server/developer_manual/core/ocs-capabilities.html#available-capabilities?

yes 👍

@settermjd
Copy link
Contributor Author

@michaelstingl, the capability has been documented. Is this PR ready for merge?

@michaelstingl
Copy link
Contributor

@michaelstingl, the capability has been documented. Is this PR ready for merge?

Add a new section below with the explanation?

@settermjd
Copy link
Contributor Author

@michaelstingl, the capability has been documented. Is this PR ready for merge?

Add a new section below with the explanation?

Does a9a3833 do what you're after?

michaelstingl
michaelstingl approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, should work now

My local build:
OCS_Rest_API____ownCloud_Documentation

@settermjd settermjd merged commit 397c02c into master May 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the document-link-to-open-file-sidebar-from-permalink branch May 28, 2019 12:59
settermjd added a commit that referenced this pull request May 28, 2019
@settermjd
[10.0] [PR 1228] Document ability to open the file sidebar from a per…
8f8d1c9 
…malink

Backport of PR #1228
settermjd added a commit that referenced this pull request May 28, 2019
@settermjd
[10.1] [PR 1228] Document ability to open the file sidebar from a per…
fea9bbf 
…malink

Backport of PR #1228
settermjd added a commit that referenced this pull request May 28, 2019
@settermjd
[10.2] [PR 1228] Document ability to open the file sidebar from a per…
6bc1810 
…malink

Backport of PR #1228
This was referenced May 28, 2019
Merged
Merged
Merged
phil-davis pushed a commit that referenced this pull request May 28, 2019
@settermjd @phil-davis
[10.2] [PR 1228] Document ability to open the file sidebar from a per…
a6baa0a 
…malink

Backport of PR #1228
phil-davis pushed a commit that referenced this pull request May 28, 2019
@settermjd @phil-davis
[10.0] [PR 1228] Document ability to open the file sidebar from a per…
2b92f79 
…malink

Backport of PR #1228
phil-davis pushed a commit that referenced this pull request May 28, 2019
@settermjd @phil-davis
[10.1] [PR 1228] Document ability to open the file sidebar from a per…
a1eb5c1 
…malink

Backport of PR #1228
settermjd added a commit that referenced this pull request Jul 22, 2019
@settermjd
Document ability to open the file sidebar from a permalink (#1228)
e52af3d 
* Document ability to open the file sidebar from a permalink
* Document the new privateLinksDetailsParam capability
* Add privateLinksDetailsParam to Files capabilities element description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstingl michaelstingl michaelstingl approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@settermjd settermjd

Labels
enhancement New feature or request p3-medium Normal priority user docs waiting on feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to open file sidebar from permalink
2 participants
@settermjd @michaelstingl