Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new capability privateLinksDetailsParam #35101

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

karakayasemi
Copy link
Contributor

@karakayasemi karakayasemi commented Apr 26, 2019

Description

add capability entry for this feature: #32152

Related Issue

Motivation and Context

Show clients whether this feature #32152 is supported or not.

How Has This Been Tested?

Unit tests added, also tested via ocs rest api for capabilities.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Apr 26, 2019
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #35101 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35101      +/-   ##
============================================
+ Coverage     65.45%   65.47%   +0.02%     
  Complexity    18633    18633              
============================================
  Files          1216     1216              
  Lines         70553    70544       -9     
  Branches       1296     1296              
============================================
+ Hits          46183    46192       +9     
+ Misses        23993    23975      -18     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.49% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.86% <ø> (+0.02%) 18633 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 100% <ø> (+100%) 2 <0> (ø) ⬇️
lib/private/Files/View.php 84.6% <0%> (+0.3%) 398% <0%> (ø) ⬇️
lib/private/DB/Connection.php 66.17% <0%> (+0.73%) 49% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432dd0c...8e0b6a7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #35101 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35101      +/-   ##
============================================
+ Coverage     65.45%   65.47%   +0.02%     
  Complexity    18633    18633              
============================================
  Files          1216     1216              
  Lines         70553    70544       -9     
  Branches       1296     1296              
============================================
+ Hits          46183    46192       +9     
+ Misses        23993    23975      -18     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.49% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.86% <ø> (+0.02%) 18633 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 100% <ø> (+100%) 2 <0> (ø) ⬇️
lib/private/Files/View.php 84.6% <0%> (+0.3%) 398% <0%> (ø) ⬇️
lib/private/DB/Connection.php 66.17% <0%> (+0.73%) 49% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432dd0c...8e0b6a7. Read the comment docs.

@karakayasemi karakayasemi merged commit f1eeb53 into master Apr 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the privateLinksDetailsParam branch April 26, 2019 13:02
@karakayasemi
Copy link
Contributor Author

@PVince81 backporting to release-10.2.0 ?

@karakayasemi
Copy link
Contributor Author

release-10.2.0: #35104

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to open file sidebar from permalink
2 participants