Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for propfind depth infinity should be false as in the past #40016

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Apr 25, 2022

Change in https://github.com/owncloud/core/pull/38583/files#diff-efe547293d3c10c67f8014fd439977f1c8f1073dcb65a1a83dc33e7d266dec70R48 release for oc10.9 set dav.propfind.depth_infinity' => true as default and caused some performance issues on some setups. This PR brings back the default as in the past, as discussed in #38583 (comment).

  • review unit tests for potential adjustments

fixes https://github.com/owncloud/enterprise/issues/5154

@mrow4a mrow4a self-assigned this Apr 25, 2022
@mrow4a mrow4a changed the title default for propfind depth infinity should be false as in the past WIP: default for propfind depth infinity should be false as in the past Apr 25, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Apr 25, 2022

💥 Acceptance tests pipeline apiComments-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35465/51

@mmattel
Copy link
Contributor

mmattel commented Apr 26, 2022

Hooking myself in to get notified when merged so we can start a config-to-docs run.
@EParzefall FYI

@phil-davis
Copy link
Contributor

phil-davis commented Apr 26, 2022

Note: I am working on the acceptance tests in PR #40021 so that I don't make a mess of this PR.

I will first get them passing, then sort out adding a few scenarios to test:
a) what happens when a client does send a depth infinity request, but depth infinity is disabled
b) enabling depth infinity and a few test cases to be confident that it generally works

@jvillafanez
Copy link
Member

The solution itself looks good, but I think we should clarify the doc in the config.sample

@mrow4a mrow4a changed the title WIP: default for propfind depth infinity should be false as in the past Default for propfind depth infinity should be false as in the past Apr 26, 2022
@mrow4a mrow4a requested a review from jvillafanez April 26, 2022 19:54
@mrow4a
Copy link
Contributor Author

mrow4a commented Apr 26, 2022

@phil-davis I think we should first have this change and then add acceptance on this basis.

@phil-davis
Copy link
Contributor

phil-davis commented Apr 27, 2022

@phil-davis I think we should first have this change and then add acceptance on this basis.

agree - we just need to do the minimal change to the acceptance tests so that the current tests pass. I will keep working on that in #40021

@owncloud owncloud deleted a comment from update-docs bot Apr 29, 2022
@phil-davis
Copy link
Contributor

I rebased and pushed the test changes from #40021

IMO CI should pass and we can merge.

@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants