Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance tests for Default for propfind depth infinity should be false as in the past #40035

Closed
phil-davis opened this issue Apr 29, 2022 · 3 comments
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

The default was changed in PR #40016 which has been merged to core master. The existing tests are all passing, and some of those explicitly check that infinite depth PROPFIND works when it is enabled.

Add some tests for:

  • infinite depth PROPFIND is disabled, check doing various PROPFIND requests that ask for depth infinity and check the response (they should give some 4xx HTTP status)
  • review the coverage of tests that have infinite depth PROPFIND enabled. Add a few tests so that there is reasonable coverage, to avoid accidental regression of the infinite depth PROPFIND behavior in future.
@SagarGi SagarGi self-assigned this May 6, 2022
@SagarGi
Copy link
Member

SagarGi commented May 9, 2022

@phil-davis by default propfind depth infinity is set to false but still but the system config key is not set for dav.propfind.depth_infinity and it allows depth infinity untill And the administrator has set depth_infinity_allowed to 0 this step is invoked. so is above step compulsory for scenarios to not to allow depth infinity or the default should have done the same?

@phil-davis
Copy link
Contributor Author

@SagarGi if dav.propfind.depth_infinity is not mentioned at all in config.php then the system should have it disabled - PROPFIND with depth infinity should return 412 (or some 4xx HTTP status).

Please check on a local system, and then maybe we need to debug the test code to see why there is unexpected behavior.

@SagarGi
Copy link
Member

SagarGi commented May 11, 2022

Tests has been added for dav.propfind.depth_infinity disabled. Closing this issue.

@SagarGi SagarGi closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants