default for propfind depth infinity should be false as in the past

owncloud · Apr 25, 2022 · 6b9ee22 · 6b9ee22
1 parent 294d40d
commit 6b9ee22
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/apps/dav/lib/Capabilities.php b/apps/dav/lib/Capabilities.php
@@ -45,7 +45,7 @@ public function getCapabilities() {
 					'search-files',
 				],
 				'propfind' => [
-					'depth_infinity' => $this->config->getSystemValue('dav.propfind.depth_infinity', true),
+					'depth_infinity' => $this->config->getSystemValue('dav.propfind.depth_infinity', false),
 				]
 			]
 		];

diff --git a/apps/dav/lib/Connector/Sabre/ServerFactory.php b/apps/dav/lib/Connector/Sabre/ServerFactory.php
@@ -140,7 +140,7 @@ public function createServer(
 		$server->on('beforeMethod:PROPFIND', function (Request $request) use ($config) {
 			$depthHeader = strtolower($request->getHeader('depth'));
 
-			if ($depthHeader === 'infinity' && !$config->getSystemValue('dav.propfind.depth_infinity', true)) {
+			if ($depthHeader === 'infinity' && !$config->getSystemValue('dav.propfind.depth_infinity', false)) {
 				throw new PreconditionFailed('Depth infinity not supported');
 			}
 		}, 0);

diff --git a/apps/dav/lib/Server.php b/apps/dav/lib/Server.php
@@ -244,7 +244,7 @@ public function __construct(IRequest $request, $baseUri) {
 		$this->server->on('beforeMethod:PROPFIND', function (Request $request) use ($config) {
 			$depthHeader = strtolower($request->getHeader('depth'));
 
-			if ($depthHeader === 'infinity' && !$config->getSystemValue('dav.propfind.depth_infinity', true)) {
+			if ($depthHeader === 'infinity' && !$config->getSystemValue('dav.propfind.depth_infinity', false)) {
 				throw new Exception\PreconditionFailed('Depth infinity not supported');
 			}
 		}, 0);

diff --git a/changelog/unreleased/40016 b/changelog/unreleased/40016
@@ -0,0 +1,7 @@
+Bugfix: default for propfind depth infinity adjusted
+
+Fixed potential cause for performance issues under certain conditions 
+with infinite propfind being enabled by default. 
+
+https://github.com/owncloud/core/pull/40016
+https://github.com/owncloud/enterprise/issues/5154
diff --git a/config/config.sample.php b/config/config.sample.php
@@ -1696,11 +1696,11 @@
 /**
  * Allow propfind depth infinity
  *
- * With this setting that defaults to true, propfind requests will now be streamed to reduce memory usage
+ * With this setting enabled propfind requests can be streamed to reduce memory usage
  * with large responses. It tells the clients whether `depth=infinity` is allowed for propfind requests.
  * For details see: https://datatracker.ietf.org/doc/html/rfc4918#section-10.2
  */
-'dav.propfind.depth_infinity' => true,
+'dav.propfind.depth_infinity' => false,
 
 /**
  * Show the grace period popup