Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] owncloud coding standard #32103

Closed
wants to merge 14 commits into from
Closed

Conversation

phil-davis
Copy link
Contributor

Backport #31442

The first commits backport the various interim php-cs-fixer changes from PR #31198 #31236 #31250 #31271 #31273

That was the easy way to make a list of cherry-picks that all fit nicely on top of each other. And it brings along the Makefile and drone changes etc that were already done before #31442

The last commits use php-cs-fixer to make the automatic fixes needed for the code in stable10

lib/composer/bin/php-cs-fixer fix -v --diff --diff-format udiff --allow-risky yes

@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #32103 into stable10 will increase coverage by 0.34%.
The diff coverage is 70.98%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #32103      +/-   ##
==============================================
+ Coverage       62.33%   62.68%   +0.34%     
+ Complexity      18696    18686      -10     
==============================================
  Files            1215     1215              
  Lines           73155    73253      +98     
  Branches         1276     1276              
==============================================
+ Hits            45600    45915     +315     
+ Misses          27176    26959     -217     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 52.83% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.75% <70.98%> (+0.38%) 18686 <698> (-10) ⬇️
Impacted Files Coverage Δ Complexity Δ
...nnector/Sabre/Exception/PasswordLoginForbidden.php 0% <ø> (ø) 2 <0> (ø) ⬇️
apps/files/appinfo/app.php 25% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_external/appinfo/routes.php 0% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_external/lib/Command/Export.php 0% <ø> (ø) 0 <0> (ø) ⬇️
apps/dav/lib/CardDAV/ContactsManager.php 100% <ø> (ø) 4 <0> (ø) ⬇️
apps/federatedfilesharing/lib/TokenHandler.php 100% <ø> (ø) 2 <0> (ø) ⬇️
apps/files/templates/index.php 0% <ø> (ø) 0 <0> (ø) ⬇️
apps/federation/lib/Hooks.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...v/lib/Connector/Sabre/Exception/EntityTooLarge.php 0% <ø> (ø) 1 <0> (ø) ⬇️
apps/files/lib/Command/DeleteOrphanedFiles.php 100% <ø> (ø) 5 <0> (ø) ⬇️
... and 595 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc98c34...244e3ab. Read the comment docs.

@phil-davis
Copy link
Contributor Author

I got too many changes in composer.lock because I did a full composer update with each commit that has a change to composer.json

I will rebase with more selective changes to composer stuff, after little harmless things like #32107 get merged.

@phil-davis
Copy link
Contributor Author

See PR #32116

@phil-davis phil-davis closed this Jul 21, 2018
@patrickjahns patrickjahns deleted the stable10-coding-style-5 branch July 30, 2018 15:28
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants